Skip to content

tests: GNU-compat coverage for write-errors and ls TIME_STYLE (#4627) #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
naoNao89 wants to merge 19 commits into from
Closed

tests: GNU-compat coverage for write-errors and ls TIME_STYLE (#4627) #8684

naoNao89 wants to merge 19 commits into from

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Sep 20, 2025

This PR adds test coverage to improve alignment with GNU coreutils for ls, tee, and cat as part of addressing regressions tracked in #4627.

Summary of changes

  • ls: Add focused tests for TIME_STYLE behavior and precedence
    • TIME_STYLE from environment (e.g., TIME_STYLE=full-iso)
    • --time-style=iso formatting for recent vs older timestamps
    • Precedence and interaction between --full-time and --time-style (last one wins)
    • Behavior under LC_ALL=POSIX (posix-* fallbacks / locale-style formatting)
    • Sorting effects without -l when using time keys (-u/-c), to reflect GNU behavior
  • tee: Add tests for --output-error
    • Presence-only flag defaults to warn-nopipe
    • Broken-pipe robustness (no crash; exit status and stderr tolerant to platform differences)
    • Error reporting on invalid output targets
  • cat: Add broken pipe test
    • Verifies robustness in the face of SIGPIPE-like conditions without crashing
    • Removed an invalid test that used an unsupported -o flag

Issue linkage

  • Refs Regressions compared to GNU coreutils 9.2, 9.3 and 9.4 #4627
  • The added tests directly map to the remaining GNU test cases highlighted in the issue:
    • tests/misc/tee.sh
    • tests/misc/write-errors.sh (tee and cat broken pipe behavior)
    • tests/ls/ls-time.sh (TIME_STYLE, precedence, locale behavior, and time-sorting without -l)

Local validation

  • cargo test -p uu_ls -p uu_tee -p uu_cat --tests succeeds locally.
  • cargo fmt and targeted cargo clippy (uu_ls, uu_tee, uu_cat) pass locally.

Implementation notes

  • Tests are written to be robust across platforms. For broken pipe scenarios, assertions avoid brittle, platform-specific exit codes and focus on non-crash behavior and presence of diagnostics where applicable. Some tests are guarded with #[cfg(unix)] to reflect SIGPIPE semantics.
  • If CI reports failures, they may indicate platform differences or real implementation gaps. We’re happy to follow up with additional fixes in separate PRs where needed (e.g., refining tee’s --output-error behavior, ls TIME_STYLE edge cases, or cat’s SIGPIPE handling) to further close the gap with GNU coreutils.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8684 will not alter performance

Comparing naoNao89:test/gnu-compat_write-errors_and_ls-time-style_4627 (b34140c) with main (5c15d79)

Summary

✅ 41 untouched
⏩ 64 skipped1

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from 042f6a4 to cdaf2be Compare September 21, 2025 14:19
@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from cdaf2be to c72abe0 Compare September 21, 2025 14:24
@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from f502f9b to 17d4da3 Compare September 21, 2025 20:11
@naoNao89
linux: gate SELinux code to Linux; fix cat broken pipe test
6ac5031 
- chcon, runcon: replace crate-level cfg with entrypoint guard and add a no-op main on non-Linux to avoid build failures.

- ls: enable SELinux support only when both feature="selinux" and target_os="linux"; default to false otherwise.

- tests(by-util/test_cat.rs): correctly drop the read_end handle to ensure writers see EPIPE (rename _read_end -> read_end and drop it).

Refs: uutils#4627
@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from 17d4da3 to 6ac5031 Compare September 21, 2025 20:28
@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@naoNao89
tests(tee): skip broken-pipe early termination test on FreeBSD to avo…
30835b7 
…id CI hangs (PR uutils#8684)\n\n- Guard test with #[cfg(all(unix, not(target_os = "freebsd")))]\n- Rationale: FreeBSD workflow repeatedly times out on this test in vmactions/freebsd-vm\n- Keeps coverage on other Unix platforms while unblocking FreeBSD CI
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Sep 22, 2025
@naoNao89
ci: retrigger workflows to validate FreeBSD tee test skip (refs PR uu…
2cce039 
…tils#8684)
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from 2cce039 to e777d86 Compare September 22, 2025 11:50
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 22, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

GNU testsuite comparison:

GNU test failed: tests/tail/overlay-headers. tests/tail/overlay-headers is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

sylvestre
sylvestre reviewed Sep 26, 2025
View reviewed changes
sylvestre
sylvestre reviewed Sep 26, 2025
View reviewed changes
sylvestre
sylvestre reviewed Sep 26, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@naoNao89
test: address review feedback and harden GNU-compat tests; fix SELinu…
82646c7 
…x gating for ls

- chcon/runcon: add rationale comments for item-level cfg with stub main() on non-Linux
  to keep binary targets present across platforms (fixes reviewer request)
- cat tests: remove top-of-file banner; add scoped comment and replace tautology
  with assert on process exit to ensure no hang/crash in broken pipe scenario
- tee tests: replace tautological assertion with explicit exit presence check
  in broken pipe scenario (Unix, non-FreeBSD)
- ls: gate SecurityContext lookup under all(feature=selinux, target_os=linux) to
  avoid unresolved symbols when building with all features; maintain String
  return path across cfg branches

These changes address @sylvestre’s comments and improve cross-platform stability
while preserving GNU-compat coverage for TIME_STYLE, broken pipes, and stdbuf.
@github-actions
Copy link

github-actions bot commented Sep 26, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Ecordonnier
Ecordonnier reviewed Sep 26, 2025
View reviewed changes
@naoNao89
tests: address review feedback and stabilize GNU-compat coverage for PR
4e90de7 
uutils#8684

- cat: move broken pipe test below header; on Unix assert nonzero exit
- ls: add TZ=UTC to time-style tests; make sorting deterministic via touch -d (fallback to 2s sleep)
- tee: add Unix presence-only --output-error broken-pipe test (assert exit only; add TODO to tighten)
- stdbuf: add prominent TODO for GNU-like lib lookup order to fix brittle tests
- df: fix test_total parsing by using --output=size,used,avail --total to avoid non-numeric columns
- cspell wordlist: place EPIPE in alphabetical order and remove extra blank line

Also ran cargo fmt to satisfy formatting.
@naoNao89
Merge branch 'main' into test/gnu-compat_write-errors_and_ls-time-sty…
09ded48 
…le_4627
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@naoNao89
tests(ls): fix unused variable in test_ls_time_sort_without_long when…
e8aba43 
… touch feature is disabled

Define 'at' only in the #[cfg(not(feature = "touch"))] branch to avoid -D warnings unused variable error. No behavior change; affects tests only.
@naoNao89 naoNao89 force-pushed the test/gnu-compat_write-errors_and_ls-time-style_4627 branch from 3841485 to e8aba43 Compare September 29, 2025 01:50
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@Ecordonnier Ecordonnier mentioned this pull request Sep 29, 2025
Merged
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

sylvestre commented Sep 29, 2025

sorry for the latency
please split this PR into several

One PR = one class of change
you are mixing too many different kind of changes. thanks

This was referenced Oct 3, 2025
Merged
Merged
Open
naoNao89 added a commit to naoNao89/coreutils that referenced this pull request Oct 3, 2025
@naoNao89
cspell: whitelist EPIPE to fix Style/spelling on PR uutils#8798 (spli…
4999753 
…t from uutils#8684 / tracked in uutils#4627)
@naoNao89 naoNao89 closed this Oct 3, 2025
@naoNao89 naoNao89 deleted the test/gnu-compat_write-errors_and_ls-time-style_4627 branch December 15, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

+3 more reviewers

@Ecordonnier Ecordonnier Ecordonnier left review comments

@orhun orhun orhun left review comments

@oech3 oech3 oech3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naoNao89 @sylvestre @Ecordonnier @orhun @oech3