add support for systemd-logind #8483

Ecordonnier · 2025-08-14T20:57:40Z

Add support for systemd-logind for systems where /var/run/utmp does not exist any more (e.g. Ubuntu 25.04).

Here is some context explaining the switch from utmp to systemd-logind:
https://www.thkukuk.de/blog/Y2038_glibc_utmp_64bit/

For debian/ubuntu, utmp was disabled in systemd build options in version 256.7 (see https://lists.debian.org/debian-user/2024/11/msg00140.html ). For reference this means that utmp is still enabled in Ubuntu 24.10 and gets disabled first with Ubuntu 25.04 (important for the CI tests).

Fixes #8376

github-actions · 2025-08-15T11:38:03Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions · 2025-08-15T12:13:00Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-08-15T13:19:05Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-08-15T22:13:59Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions · 2025-08-15T23:00:52Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-08-16T14:45:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-08-16T17:30:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-08-16T18:24:05Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)

github-actions · 2025-08-16T22:20:27Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

Add support for systemd-logind for systems where `/var/run/utmp` does not exist any more (e.g. Ubuntu 25.04). Here is some context explaining the switch from utmp to systemd-logind: https://www.thkukuk.de/blog/Y2038_glibc_utmp_64bit/ Fixes uutils#8376 Signed-off-by: Etienne Cordonnier <[email protected]>

github-actions · 2025-08-17T21:36:45Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

Ecordonnier · 2025-08-18T09:19:26Z

I think the PR is good to go (I've undrafted it). Highlighting this comment here, since I had to implement what I consider a GNU coreutils bug to keep uutils-coreutils compatible. On Ubuntu 25.05 "uptime -s" and "who -b" can print a different minute value. I'll try to follow up with GNU coreutils, but I don't know when I will have the time:

    /// Get system boot time using systemd random-seed file fallback
    ///
    /// TODO: This replicates GNU coreutils' fallback behavior for compatibility.
    /// GNU coreutils uses the mtime of /var/lib/systemd/random-seed as a heuristic for boot time
    /// when utmp is unavailable, rather than querying systemd's authoritative KernelTimestamp.
    /// This creates inconsistency: `uptime -s` shows the actual kernel boot time
    /// while `who -b` shows ~1 minute later when systemd services start.
    ///
    /// Ideally, both should use the same source (KernelTimestamp) for semantic consistency.
    /// Consider proposing to GNU coreutils to use systemd's KernelTimestamp property instead.

src/uucore/src/lib/features/utmpx.rs

cakebaker · 2025-08-20T15:10:57Z

There seems to be a bug when using the feat_systemd_logind feature:

$ cargo run -q --features=unix who -b
         system boot  Aug 20 07:35
$ cargo run -q --features=feat_systemd_logind who -b
         system boot  Aug 20 07:35
         system boot  Aug 20 07:35

$ cargo run -q --features=unix users
dho dho dho dho dho dho dho
$ cargo run -q --features=feat_systemd_logind users
dho dho dho dho dho dho dho dho dho

src/uucore/src/lib/features/utmpx.rs

sylvestre · 2025-08-20T17:13:59Z

src/uucore/src/lib/features/utmpx.rs

+    fn new_systemd() -> Self {
+        // PoisonErrors can safely be ignored
+        let guard = LOCK.lock().unwrap_or_else(|err| err.into_inner());
+        let systemd_iter = systemd_logind::SystemdUtmpxIter::new().ok();


what happen in case of error here ?
thanks

I've reworked that part to return an empty iterator in case of error, and added comments as well

src/uucore/src/lib/features/systemd_logind.rs

Ecordonnier · 2025-08-20T21:41:25Z

There seems to be a bug when using the feat_systemd_logind feature:

$ cargo run -q --features=unix who -b
         system boot  Aug 20 07:35
$ cargo run -q --features=feat_systemd_logind who -b
         system boot  Aug 20 07:35
         system boot  Aug 20 07:35

$ cargo run -q --features=unix users
dho dho dho dho dho dho dho
$ cargo run -q --features=feat_systemd_logind users
dho dho dho dho dho dho dho dho dho

Sorry about that. I wasn't hitting this bug on my development machine because 25.04 has no utmp any more. Also something is wrong in the CI setup, because "test_boot()" should have catched this.

It's working now:

ecordonnier@LBM9V6C4:~/dev/coreutils$ cargo run -q --features=unix users
ecordonnier ecordonnier
ecordonnier@LBM9V6C4:~/dev/coreutils$ cargo run -q --features=feat_systemd_logind users
ecordonnier ecordonnier
ecordonnier@LBM9V6C4:~/dev/coreutils$ cargo run -q --features=unix who -b
         system boot  Aug 20 20:41
ecordonnier@LBM9V6C4:~/dev/coreutils$ cargo run -q --features=feat_systemd_logind who -b
         system boot  Aug 20 20:41

github-actions · 2025-08-20T22:02:21Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

src/uucore/src/lib/features/systemd_logind.rs

Co-authored-by: Daniel Hofstetter <[email protected]>

getpwuid() is not thread-safe. Signed-off-by: Etienne Cordonnier <[email protected]>

Signed-off-by: Etienne Cordonnier <[email protected]>

github-actions · 2025-08-21T19:18:39Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

Signed-off-by: Etienne Cordonnier <[email protected]>

github-actions · 2025-08-21T21:54:03Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Ecordonnier · 2025-08-21T22:20:41Z

Maybe something needs to be done about the tests. If running on Ubuntu < 25.04, the tests should use utmp. If running on Ubuntu >= 25.04, the tests should use feat_systemd_logind. This can be automatically detected by using "systemctl --version" which shows whether systemd is compiled with UTMP support or not. This could also be configured manually in the CI files.

Right now cargo test --features feat_systemd_logind is passing in CI, failing on Ubuntu 24.04, and working on Ubuntu 25.04 (GNU coreutils is compiled for systemd-logind support on Ubuntu 25.04).

Please also note that I'm available tomorrow, and then gone for a week.

src/uucore/src/lib/features/systemd_logind.rs

Signed-off-by: Etienne Cordonnier <[email protected]>

github-actions · 2025-08-22T11:16:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

Signed-off-by: Etienne Cordonnier <[email protected]>

Ecordonnier · 2025-08-22T11:38:08Z

Commit 20f4da0 is not a change requested in the review, however I think it makes sense: with this change, packagers of distributions based on systemd won't need to change anything in the build process and won't accidentally ship e.g. a broken "who".

Edit: I reverted. It will require bigger changes in CI.

This breaks "Tests/BusyBox test suite" in CI. This reverts commit 16626d4.

github-actions · 2025-08-22T12:05:32Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

Ecordonnier force-pushed the eco/utmp-systemd branch from 06b8e1f to 50c02c5 Compare August 15, 2025 12:59

Ecordonnier force-pushed the eco/utmp-systemd branch from fdbf24d to 7fc6292 Compare August 15, 2025 22:41

Ecordonnier mentioned this pull request Aug 15, 2025

who, pinky are empty - need to talk to logind #8376

Closed

Ecordonnier force-pushed the eco/utmp-systemd branch from 7fc6292 to b2cb313 Compare August 16, 2025 14:26

Ecordonnier force-pushed the eco/utmp-systemd branch from b2cb313 to 9c853b8 Compare August 16, 2025 17:11

Ecordonnier force-pushed the eco/utmp-systemd branch from 9c853b8 to a206a94 Compare August 16, 2025 18:04

Ecordonnier force-pushed the eco/utmp-systemd branch from a206a94 to 7995bb1 Compare August 16, 2025 22:01

Ecordonnier marked this pull request as draft August 16, 2025 22:10

Ecordonnier force-pushed the eco/utmp-systemd branch 2 times, most recently from 9e9c61c to 20b4f46 Compare August 17, 2025 21:02

Ecordonnier changed the title ~~work in progress - add support for systemd-logind~~ add support for systemd-logind Aug 17, 2025

Ecordonnier marked this pull request as ready for review August 17, 2025 21:14

Ecordonnier force-pushed the eco/utmp-systemd branch from 20b4f46 to b48eac2 Compare August 17, 2025 21:16

cakebaker reviewed Aug 20, 2025

View reviewed changes

src/uucore/src/lib/features/utmpx.rs Show resolved Hide resolved

sylvestre reviewed Aug 20, 2025

View reviewed changes

src/uucore/src/lib/features/utmpx.rs Outdated Show resolved Hide resolved

sylvestre reviewed Aug 20, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Outdated Show resolved Hide resolved

cakebaker reviewed Aug 21, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Outdated Show resolved Hide resolved

cakebaker reviewed Aug 21, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Outdated Show resolved Hide resolved

Ecordonnier and others added 5 commits August 21, 2025 21:17

improve error forwarding

7c9c774

Co-authored-by: Daniel Hofstetter <[email protected]>

remove unnecessary negation in if/else block

524e230

Co-authored-by: Daniel Hofstetter <[email protected]>

use getpwuid_r() instead of getpwuid()

76d55cf

getpwuid() is not thread-safe. Signed-off-by: Etienne Cordonnier <[email protected]>

improve error handling

29aa34b

Signed-off-by: Etienne Cordonnier <[email protected]>

use Path instead of string

21aab01

Signed-off-by: Etienne Cordonnier <[email protected]>

use closure to reduce the number of clones() calls

d63813a

Signed-off-by: Etienne Cordonnier <[email protected]>

Ecordonnier force-pushed the eco/utmp-systemd branch from 72d97b0 to d63813a Compare August 21, 2025 21:32

sylvestre reviewed Aug 22, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Outdated Show resolved Hide resolved

sylvestre reviewed Aug 22, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Show resolved Hide resolved

sylvestre reviewed Aug 22, 2025

View reviewed changes

src/uucore/src/lib/features/systemd_logind.rs Outdated Show resolved Hide resolved

Ecordonnier added 4 commits August 22, 2025 10:56

use MaybeUninit instead of mem::zeroed()

4ed58c9

Signed-off-by: Etienne Cordonnier <[email protected]>

systemd-logind: add some unit-tests

90c41d9

Signed-off-by: Etienne Cordonnier <[email protected]>

use sysconf(_SC_GETPW_R_SIZE_MAX) instead of 1024

ed15bf9

Signed-off-by: Etienne Cordonnier <[email protected]>

fix cspell

a0911d5

Signed-off-by: Etienne Cordonnier <[email protected]>

add auto-enablement of feat_systemd_logind in GNUmakefile

16626d4

Signed-off-by: Etienne Cordonnier <[email protected]>

Ecordonnier force-pushed the eco/utmp-systemd branch from 20f4da0 to 16626d4 Compare August 22, 2025 11:36

Revert "add auto-enablement of feat_systemd_logind in GNUmakefile"

e26cbfb

This breaks "Tests/BusyBox test suite" in CI. This reverts commit 16626d4.

sylvestre merged commit bba4d99 into uutils:main Aug 23, 2025
92 checks passed

Ecordonnier deleted the eco/utmp-systemd branch August 23, 2025 17:15

lcheylus mentioned this pull request Nov 6, 2025

Fix test job in FreeBSD workflow #9155

Merged

Uh oh!

add support for systemd-logind #8483

add support for systemd-logind #8483

Uh oh!

Conversation

Ecordonnier commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 16, 2025

Uh oh!

github-actions bot commented Aug 17, 2025

Uh oh!

Ecordonnier commented Aug 18, 2025

Uh oh!

Uh oh!

cakebaker commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sylvestre Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Ecordonnier Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Ecordonnier commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

github-actions bot commented Aug 21, 2025

Uh oh!

Ecordonnier commented Aug 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

Ecordonnier commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ecordonnier commented Aug 14, 2025 •

edited

Loading

cakebaker commented Aug 20, 2025 •

edited

Loading

Ecordonnier commented Aug 20, 2025 •

edited

Loading

Ecordonnier commented Aug 22, 2025 •

edited

Loading