install: Fix --no-target-directory with existing file #8412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
install should silently override existing target files, but it inadvertently checked whether the target exists rather than for the target being a directory, hence the overwrite failed, saying it cannot overwrite the directory with non-directory. Bug-Ubuntu: https://bugs.launchpad.net/bugs/2118785
julian-klode
force-pushed
the
fix-install-no-target-existing-target
branch
from
1e5987f to
190ddd1
Compare
Contributor
Author
|
Fixed style issue - I just learned I can run |
|
GNU testsuite comparison: |
Contributor
|
well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install should silently override existing target files, but it inadvertently checked whether the target exists rather than for the target being a directory, hence the overwrite failed, saying it cannot overwrite the directory with non-directory.
Bug-Ubuntu: https://bugs.launchpad.net/bugs/2118785