Skip to content

env: use execvp instead of Command::status on Unix systems #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 1 commit into from
Jul 22, 2025
Merged

env: use execvp instead of Command::status on Unix systems #8365

cakebaker merged 1 commit into from
Jul 22, 2025

Conversation

@yuankunzhang
Copy link
Contributor

@yuankunzhang yuankunzhang commented Jul 21, 2025

Closes #8361.

@github-actions
Copy link

github-actions bot commented Jul 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

aleasto
aleasto reviewed Jul 21, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 22, 2025
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy complains about two unneeded return statements on Windows, otherwise it looks good.

@yuankunzhang
Copy link
Contributor Author

yuankunzhang commented Jul 22, 2025

clippy complains about two unneeded return statements on Windows, otherwise it looks good.

Addressed.

@cakebaker cakebaker merged commit 8e83822 into uutils:main Jul 22, 2025
112 of 114 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Jul 22, 2025

Thanks!

@BrewTestBot BrewTestBot mentioned this pull request Sep 6, 2025
Merged
@Ecordonnier Ecordonnier mentioned this pull request Nov 26, 2025
Closed
@Ecordonnier
Copy link
Contributor

Ecordonnier commented Dec 9, 2025 •
edited
Loading

@yuankunzhang can you please have a look at #9614 , it uses Command::exec() instead of the call to libc::execvp() which was introduced in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker approved these changes

+1 more reviewer

@aleasto aleasto aleasto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

env(1) forks, but must exec() directly

4 participants

@yuankunzhang @cakebaker @Ecordonnier @aleasto