Skip to content

tests/install/install-Z-selinux: fix selinux for install #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 1 commit into from
Oct 22, 2025
Merged

tests/install/install-Z-selinux: fix selinux for install #8307

cakebaker merged 1 commit into from
Oct 22, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jul 3, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Jul 12, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Jul 14, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Jul 15, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Jul 16, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre sylvestre marked this pull request as ready for review July 25, 2025 14:28
@sylvestre sylvestre requested a review from cakebaker July 25, 2025 14:28
@sylvestre sylvestre changed the title Install selinux tests/install/install-Z-selinux: fix selinux Jul 25, 2025
@sylvestre sylvestre changed the title tests/install/install-Z-selinux: fix selinux tests/install/install-Z-selinux: fix selinux for install Jul 25, 2025
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
cakebaker
cakebaker reviewed Jul 26, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre sylvestre force-pushed the install-selinux branch 3 times, most recently from b268db4 to 8e81ec6 Compare July 27, 2025 19:39
@github-actions
Copy link

github-actions bot commented Jul 27, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre sylvestre requested a review from cakebaker July 28, 2025 05:34
cakebaker
cakebaker reviewed Jul 28, 2025
View reviewed changes
src/uu/install/src/install.rs Outdated
/// # Returns
///
/// Returns `Ok(())` if the context was successfully set, or a `SeLinuxError` if the operation failed.
pub fn set_selinux_default_context_for_install(path: &Path) -> Result<(), SeLinuxError> {
Copy link
Contributor

@cakebaker cakebaker Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would shorten the name to just set_selinux_default_context.

cakebaker
cakebaker reviewed Jul 28, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Sep 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre sylvestre force-pushed the install-selinux branch 2 times, most recently from 82878ae to cc8ee03 Compare September 11, 2025 22:04
@github-actions
Copy link

github-actions bot commented Sep 11, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre sylvestre requested a review from cakebaker September 12, 2025 06:27
@cakebaker
Copy link
Contributor

cakebaker commented Sep 12, 2025 •
edited
Loading

The update of ctrlc to 3.5.0 doesn't work on Redox, so I would downgrade it to the previous version. The PR also contains an unrelated commit.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@github-actions
Copy link

github-actions bot commented Oct 21, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@sylvestre
Install: implement -Z
2434c2a 
Fixes: tests/install/install-Z-selinux
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

@cakebaker cakebaker merged commit 8d891bb into uutils:main Oct 22, 2025
122 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Oct 22, 2025

Congrats! The gnu test tests/install/install-Z-selinux is no longer failing!

Great, kudos :)

@sylvestre sylvestre deleted the install-selinux branch October 22, 2025 15:56
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request Oct 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @cakebaker