Skip to content

Conversation

@cakebaker
Copy link
Contributor

@cakebaker cakebaker commented Apr 24, 2025

Fixes #7835

The PR should get the CI back to green and does the following things:

  • adapts an error message to match the one from GNU id 9.7
  • simplifies the test_id_default_format and test_id_zero tests by extracting three new test functions that ensure a specific error message is shown
  • removes all [#[cfg(unix)] in the tests because id is unix-only

@cakebaker cakebaker changed the title id: adapt error message to match id: adapt error message to match the one from GNU id Apr 24, 2025
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@sylvestre sylvestre merged commit c8505d4 into uutils:main Apr 24, 2025
108 of 109 checks passed
@cakebaker cakebaker deleted the id_fix_7835 branch April 25, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

id: the tests test_id_default_format & test_id_zero fail

2 participants