Skip to content

Conversation

@jfinkels
Copy link
Collaborator

Fixes #7254.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/test/test is no longer failing!

@sylvestre
Copy link
Contributor

would it be possible to add tests with more complex string ? utf8 char, broken input, etc?
thanks

@jfinkels
Copy link
Collaborator Author

I added just a few more, including strings with spaces, strings of different lengths, empty strings, and Unicode.

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/test/test is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/test/test is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker force-pushed the test-string-comparison-lt-gt branch from 985c82a to d8058f2 Compare February 21, 2025 10:41
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/usage_vs_getopt (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/test/test is no longer failing!

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/test/test is no longer failing!

ouhlala :)

@cakebaker cakebaker merged commit 4acc59d into uutils:main Feb 21, 2025
65 checks passed
@cakebaker
Copy link
Contributor

Congrats! The gnu test tests/test/test is no longer failing!

Great, thanks :)

sylvestre pushed a commit to sylvestre/coreutils that referenced this pull request Feb 24, 2025
* test: add < and > operators for string comparison

Fixes uutils#7254.

* Add more tests for string inequality

* Use match in place of if/elseif block

Co-authored-by: Daniel Hofstetter <[email protected]>

* Change test name to specify lt/gt operator

---------

Co-authored-by: Daniel Hofstetter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: errors on '<' operator

3 participants