uptime: refactor, move some codes to uucore #7289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some functions throw errors, should I create a thiserror enum? or is there a existed one i can add some entries? |
|
GNU testsuite comparison: |
Bluemangoo
force-pushed
the
feature/refactor-uptime
branch
2 times, most recently
from
a4b78ae to
7fd063b
Compare
|
GNU testsuite comparison: |
Bluemangoo
force-pushed
the
feature/refactor-uptime
branch
3 times, most recently
from
2a69c60 to
c704d7f
Compare
|
GNU testsuite comparison: |
Contributor
Author
|
I encountered a problem: How to install libsystemd-dev for the corresponding arch in cross. in cross image there are no apt source for it(only amd64 and i386). For example, in armhf, I try to add source(in pre-build command, and then install): dpkg --add-architecture armhf&&echo 'deb [arch=armhf] http://ports.ubuntu.com/ bionic main restricted
deb [arch=armhf] http://ports.ubuntu.com/ bionic-updates main restricted
deb [arch=armhf] http://ports.ubuntu.com/ bionic universe
deb [arch=armhf] http://ports.ubuntu.com/ bionic-updates universe
deb [arch=armhf] http://ports.ubuntu.com/ bionic multiverse
deb [arch=armhf] http://ports.ubuntu.com/ bionic-updates multiverse
deb [arch=armhf] http://ports.ubuntu.com/ bionic-backports main restricted universe multiverse'>>/etc/apt/sources.list&&apt-get updateFailed for dependent conflicts :( |
sylvestre
force-pushed
the
feature/refactor-uptime
branch
from
c704d7f to
c6c1dc5
Compare
|
GNU testsuite comparison: |
Bluemangoo
force-pushed
the
feature/refactor-uptime
branch
from
c6c1dc5 to
585b84e
Compare
Bluemangoo
force-pushed
the
feature/refactor-uptime
branch
from
585b84e to
5a28db5
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
Done! Maintainers can start review now. |
sylvestre
reviewed
Feb 18, 2025
sylvestre
reviewed
Feb 18, 2025
Contributor
Author
|
all fixed. |
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move some code from uu_uptime to uucore, to use them in uu_top.
It may duplicate #7256. When I started, #7256 was not yet open.
I also implement Windows(except load average, it seems impossible)