Skip to content

tee: fix -p behavior upon broken pipe stdout #7273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 2 commits into from
Feb 7, 2025
Merged

tee: fix -p behavior upon broken pipe stdout #7273

cakebaker merged 2 commits into from
Feb 7, 2025

Conversation

@RenjiSann
Copy link
Collaborator

@RenjiSann RenjiSann commented Feb 5, 2025

Fixes #7073

@RenjiSann RenjiSann requested a review from jfinkels February 5, 2025 19:20
@RenjiSann RenjiSann force-pushed the tee-fix-p-broken-stdout branch 5 times, most recently from 9808af2 to f8a8e41 Compare February 5, 2025 20:31
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

jfinkels
jfinkels approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@jfinkels jfinkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense to me, and it fixes the test case. Thanks

cakebaker
cakebaker reviewed Feb 6, 2025
View reviewed changes
cakebaker
cakebaker reviewed Feb 6, 2025
View reviewed changes
@RenjiSann RenjiSann force-pushed the tee-fix-p-broken-stdout branch 2 times, most recently from 83ae7ce to 309a696 Compare February 6, 2025 09:16
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@RenjiSann RenjiSann force-pushed the tee-fix-p-broken-stdout branch from 309a696 to 64f0953 Compare February 6, 2025 11:05
@RenjiSann RenjiSann force-pushed the tee-fix-p-broken-stdout branch from 64f0953 to e550e3d Compare February 6, 2025 11:25
@github-actions
Copy link

github-actions bot commented Feb 6, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@cakebaker cakebaker merged commit 03b6371 into uutils:main Feb 7, 2025
64 of 65 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Feb 7, 2025

Thanks :)

@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
@RenjiSann RenjiSann deleted the tee-fix-p-broken-stdout branch July 1, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

@jfinkels jfinkels jfinkels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tee: -p option should terminate on closed stdout

3 participants

@RenjiSann @cakebaker @jfinkels