uptime: move to feat_common_core in Cargo.toml
#7256
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
4 times, most recently
from
341a819 to
5478140
Compare
Contributor
|
Please don't hate me for this suggestion :) |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
4 times, most recently
from
131458b to
380da40
Compare
sylvestre
force-pushed
the
uptime_enable_on_windows
branch
from
380da40 to
b991377
Compare
Contributor
|
@cakebaker still working on it? :) |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
11 times, most recently
from
4e3367a to
28e4ba7
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
28e4ba7 to
7f74c53
Compare
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
2 times, most recently
from
3277839 to
ca0c6b3
Compare
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
4 times, most recently
from
24ec87a to
43c509a
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
43c509a to
c4e96ef
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
c4e96ef to
dabed9e
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
dabed9e to
8c0acc0
Compare
|
GNU testsuite comparison: |
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
8c0acc0 to
f580003
Compare
|
GNU testsuite comparison: |
Contributor
|
@cakebaker still planning to finish it ? :) |
from feat_require_unix_utmpx
to satisfy the compiler
cakebaker
force-pushed
the
uptime_enable_on_windows
branch
from
f580003 to
1b34768
Compare
|
GNU testsuite comparison: |
Contributor
|
Is this buildable on Windows? |
Contributor
Author
|
@oech3 yes |
Contributor
|
So is merging this blocked by other platforms? |
Contributor
Author
|
Yes, there are still some CI jobs failing :| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to move
uptimefromfeat_require_unix_utmpxtofeat_common_coreinCargo.tomlbased on feedback to #7250