Skip to content

Re-enable integer overflow test case for printf #7168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 1 commit into from
Jan 19, 2025
Merged

Re-enable integer overflow test case for printf #7168

sylvestre merged 1 commit into from
Jan 19, 2025

Conversation

@jfinkels
Copy link
Collaborator

@jfinkels jfinkels commented Jan 19, 2025 •
edited
Loading

Re-enable the test case

returns_ 1 $prog '%.*dx\n' $INT_OFLOW 0 >>out 2> /dev/null || fail=1

in the GNU test file tests/printf/printf.sh. On my machine, the behavior of this command with uutils printf now matches the behavior of GNU printf:

$ printf '%.*dx\n' 2147483648 0
printf: invalid precision: '2147483648'

@github-actions
Copy link

github-actions bot commented Jan 19, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/stdbuf is no longer failing!

@jfinkels jfinkels marked this pull request as ready for review January 19, 2025 18:48
@sylvestre sylvestre merged commit 9f07d50 into uutils:main Jan 19, 2025
66 of 67 checks passed
@jfinkels jfinkels deleted the printf-test-int-overflow branch January 19, 2025 19:36
@moonfruit moonfruit mentioned this pull request Mar 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfinkels @sylvestre