Skip to content

dircolors: fix empty COLORTERM matching with ?* pattern #7089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 3 commits into from
Jan 15, 2025
Merged

dircolors: fix empty COLORTERM matching with ?* pattern #7089

cakebaker merged 3 commits into from
Jan 15, 2025

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 7, 2025

  • simplify the code

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/misc/dircolors is no longer failing!
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@github-actions
Copy link

github-actions bot commented Jan 11, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/misc/dircolors is no longer failing!

@sylvestre sylvestre requested a review from cakebaker January 13, 2025 07:53
@github-actions
Copy link

github-actions bot commented Jan 13, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/misc/dircolors is no longer failing!

cakebaker
cakebaker reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only the spell checker job complains about a few words.

@github-actions
Copy link

github-actions bot commented Jan 14, 2025

GNU testsuite comparison:

GNU test failed: tests/misc/stdbuf. tests/misc/stdbuf is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/misc/dircolors is no longer failing!

@cakebaker cakebaker merged commit d7800b5 into uutils:main Jan 15, 2025
64 of 65 checks passed
@cakebaker
Copy link
Contributor

cakebaker commented Jan 15, 2025

Congrats! The gnu test tests/misc/dircolors is no longer failing!

Well done :)

@sylvestre sylvestre deleted the dircolors branch January 15, 2025 09:41
sylvestre added a commit that referenced this pull request Jan 15, 2025
@sylvestre
dircolors is fixed by #7089
c07e0e8
cakebaker added a commit that referenced this pull request Jan 15, 2025
@cakebaker
Merge pull request #7141 from uutils/sylvestre-patch-3
6600397 
dircolors is fixed by #7089
@moonfruit moonfruit mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cakebaker cakebaker cakebaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sylvestre @cakebaker