csplit: support reading from pipe #6951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuad1502
force-pushed
the
csplit-pipe-input
branch
from
8a54b84 to
d4c0f0b
Compare
Contributor
|
@fuad1502 any update on this PR ? thanks |
sylvestre
force-pushed
the
csplit-pipe-input
branch
from
d4c0f0b to
64ce260
Compare
Contributor
Author
|
@sylvestre Hi, sorry for the long delay, I think I can handle the failing tests today 👍 There are some different behaviours in MacOS and Windows that I need to handle. |
Contributor
Author
|
@sylvestre I am having trouble with bringing up a MacOS virtual machine to debug and test the code on it. There might be some additional delay, sorry about this. In the mean time, do you know of any alternatives that I can try out other than running MacOS on VirtualBox / MacOS with Docker? I've tried both on my Ubuntu machine, but not yet successful. |
fuad1502
force-pushed
the
csplit-pipe-input
branch
from
64ce260 to
30484e9
Compare
|
GNU testsuite comparison: |
fuad1502
force-pushed
the
csplit-pipe-input
branch
3 times, most recently
from
07eaffc to
75ff8ac
Compare
Contributor
Author
|
MacOS issue fixed. It turns out |
…error message more uniformly.
…er with original csplit error
…ith all UNIX systems
cakebaker
force-pushed
the
csplit-pipe-input
branch
from
75ff8ac to
a4fdecb
Compare
Contributor
|
Thanks for your PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6461
InputIterator.UResultinstead ofio::ResultinInputIteratorfor a more uniform IO error handling.csplit.