hashsum: Windows: check in binary mode by default and allow --binary/--text #6808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It is a lot of new files just for a small change. What about checking only one kind of checksum? |
|
GNU testsuite comparison: |
Contributor
Author
|
Won't hurt for adding a second test case for all types of sums right? Since right now the only test is |
Contributor
|
yeah, adding 29 files for a simple test like this one isn't ideal |
…--text whcn checking
Pistonight
force-pushed
the
hashsum_windows
branch
from
e548a65 to
ca6d0ed
Compare
Contributor
Author
|
Updated to only check SHA256 scenarios |
|
GNU testsuite comparison: |
Contributor
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, changed hashsum with
--checkto use the same behavior as without--checkfor selecting binary/text mode, i.e. allows--binary/--textflags and default to binaryUpdated command line help message
Added binary test cases for hashsum. Using a PNG file since PNG header conveniently has
0x0D0Ain it. Verified the new test cases would fail on Windows without this changeCloses #6805