join: avoid extra allocations when using -i
#6774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWiederhake
approved these changes
Oct 9, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
LGTM!
I would be happier if there was a way to test this during CI. (Keep in mind that wrong optimizations can actually degrade performance quite badly!) But I'm optimistic enough to just accept this as-is.
Cookie points if you can find a way to do it, though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my benchmarks, this shows about 20% better performance when using
join -i.