Use github for gnulib #6762
Merged
Use github for gnulib #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - name: Override submodule URL and initialize submodules | ||
| run: | | ||
| git submodule sync --recursive | ||
| git config submodule.gnulib.url https://github.com/coreutils/gnulib.git |
Collaborator
There was a problem hiding this comment.
This effectively overrides that file, right? https://github.com/coreutils/coreutils/blob/master/.gitmodules
Contributor
Author
There was a problem hiding this comment.
nope, it adds
[submodule "gnulib"]
url = https://github.com/coreutils/gnulib.git
in .git/config
Collaborator
|
We should leave a comment or something to explain why this replacement is a good idea. Sure, today github.com seems to be vastly faster and more reliable than savannah.gnu.org, but when that changes (or if anyone reads the code) it would be nice to be told why we substitute a different repository (even if it should contain the same stuff). |
Collaborator
|
Yay, no more timeouts! |
Contributor
Author
|
and less load for the GNU project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.