mv: inter partition copying test code cleanup #6583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
BenWiederhake
requested changes
Jul 18, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
Thanks for taking this up again! In the meantime, I found/remembered the shortcut functions, maybe it's a better idea to use those? The error reporting from inside the test doesn't need to be too detailed anyway.
|
GNU testsuite comparison: |
BenWiederhake
requested changes
Jul 19, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
Looks good! Just a wrong comma. (Weird, CI should have caught that.)
Co-authored-by: Ben Wiederhake <[email protected]>
BenWiederhake
approved these changes
Jul 19, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
LGTM, the only CI failure is unrelated (#6534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code cleanup for #6578