Skip to content

printf: Fix extra padding space and wrong position of - when padding #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kev1n8 wants to merge 7 commits into from
Closed

printf: Fix extra padding space and wrong position of - when padding #6520

Kev1n8 wants to merge 7 commits into from

Conversation

@Kev1n8
Copy link
Contributor

@Kev1n8 Kev1n8 commented Jul 1, 2024 •
edited
Loading

should fix #6519 and #2774.
added some padding tests and fix the incorrect behaviors of padding

@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from fb45ff7 to c1f10f0 Compare July 2, 2024 04:12
@Kev1n8 Kev1n8 marked this pull request as ready for review July 2, 2024 04:14
@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from c1f10f0 to a1cbf06 Compare July 3, 2024 02:09
sylvestre
sylvestre reviewed Jul 3, 2024
View reviewed changes
sylvestre
sylvestre reviewed Jul 3, 2024
View reviewed changes
@Kev1n8 Kev1n8 requested a review from sylvestre July 5, 2024 07:42
sylvestre
sylvestre reviewed Jul 5, 2024
View reviewed changes
@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from b46e323 to db3f6ec Compare July 5, 2024 10:33
@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from db3f6ec to 03e1019 Compare July 5, 2024 10:36
@Kev1n8 Kev1n8 requested a review from sylvestre July 5, 2024 14:09
@Kev1n8
Copy link
Contributor Author

Kev1n8 commented Jul 6, 2024

Just added a case check, should fix the remaining issue in #2774. Before this, there was a incorrect output as following:
Screenshot 2024-07-06 at 15 22 30

@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from ecea83a to 61b85a0 Compare July 6, 2024 07:24
@sylvestre
Copy link
Contributor

sylvestre commented Jul 6, 2024

Just added a case check, should fix the remaining issue in #2774. Before this, there was a incorrect output as following: Screenshot 2024-07-06 at 15 22 30

could you please replace the screenshot by text? it is terrible for accessibility and search. thanks

sylvestre
sylvestre reviewed Jul 6, 2024
View reviewed changes
sylvestre
sylvestre reviewed Jul 6, 2024
View reviewed changes
sylvestre
sylvestre reviewed Jul 6, 2024
View reviewed changes
@Kev1n8
Copy link
Contributor Author

Kev1n8 commented Jul 6, 2024 •
edited
Loading

could you please replace the screenshot by text? it is terrible for accessibility and search. thanks

Sorry for my carelessness. The incorrect output text is as following:
/coreutils printf "%+5.1f" 2
+ 2.0%

@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from 6272ade to 6fd8ba8 Compare July 6, 2024 08:06
sylvestre
sylvestre reviewed Jul 6, 2024
View reviewed changes
@Kev1n8 Kev1n8 force-pushed the fix-extra-padding branch from 6fd8ba8 to 8e0bbe0 Compare July 6, 2024 08:28
@Kev1n8 Kev1n8 requested a review from sylvestre July 7, 2024 09:11
@Kev1n8 Kev1n8 closed this Jul 7, 2024
@Kev1n8 Kev1n8 deleted the fix-extra-padding branch July 7, 2024 11:34
@Kev1n8 Kev1n8 restored the fix-extra-padding branch July 7, 2024 11:38
@Kev1n8
Copy link
Contributor Author

Kev1n8 commented Jul 7, 2024

sorry, that was an accident.

@Kev1n8 Kev1n8 mentioned this pull request Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

printf: extra spaces if padding number is not next to %

2 participants

@Kev1n8 @sylvestre