cksum/hashsum: add support of --check with base64 + other improvs #6452

sylvestre · 2024-06-04T19:47:09Z

No description provided.

github-actions · 2024-06-04T20:13:52Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?

github-actions · 2024-06-04T20:56:21Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

github-actions · 2024-06-04T22:16:32Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

tests/by-util/test_cksum.rs

src/uucore/src/lib/features/checksum.rs

github-actions · 2024-06-05T09:50:04Z

GNU testsuite comparison:

GNU test failed: tests/timeout/timeout. tests/timeout/timeout is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

tests/by-util/test_cksum.rs

src/uucore/src/lib/features/checksum.rs

github-actions · 2024-06-18T17:16:31Z

GNU testsuite comparison:

GNU test failed: tests/rm/rm2. tests/rm/rm2 is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!
Skipping an intermittent issue tests/rm/rm1 (passes in this run but fails in the 'main' branch)

github-actions · 2024-06-18T21:24:16Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

src/uucore/Cargo.toml

github-actions · 2024-06-19T18:34:45Z

GNU testsuite comparison:

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

src/uucore/src/lib/features/checksum.rs

…<usize>)> instead of (String, Option<usize>)

github-actions · 2024-06-26T22:31:59Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

cakebaker · 2024-06-27T07:48:23Z

Congrats! The gnu test tests/cksum/cksum-base64 is no longer failing!

Great :)

sylvestre requested a review from cakebaker June 4, 2024 21:54

cakebaker reviewed Jun 5, 2024

View reviewed changes

tests/by-util/test_cksum.rs Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

sylvestre requested a review from cakebaker June 5, 2024 10:15

cakebaker reviewed Jun 5, 2024

View reviewed changes

tests/by-util/test_cksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 5, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

sylvestre requested a review from cakebaker June 18, 2024 20:58

cakebaker reviewed Jun 19, 2024

View reviewed changes

src/uucore/Cargo.toml Outdated Show resolved Hide resolved

sylvestre requested a review from cakebaker June 22, 2024 07:57

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 25, 2024

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

sylvestre added 12 commits June 25, 2024 19:00

cksum/hashsum: add support of --check with base64

66ccb1a

cksum/hashsum: move to quick-error

edae51d

cksum/hashsum: move to thiserror

cc8bda5

cksum/hashsum: move the file mgmt into a function

e6aad95

cksum/hashsum: use a struct to keep the results

a6bae64

cksum/hashsum: Move the opening into a dedicated function

520907e

cksum/hashsum: Move the algo mgmt into a dedicated function

e7898ab

cksum/hashsum: Move the algo mgmt into a dedicated function

c2292a8

cksum/hashsum: Simplify the determine_regex function

6922e7f

cksum base64: update the GNU test to manage our output

ab2cc2f

Address review comments

2e704b8

cksum: Allow the indiv build

adcc548

sylvestre requested a review from cakebaker June 25, 2024 19:24

Adjust identify_algo_name_and_length to return Option<(String, Option…

212ddf7

…<usize>)> instead of (String, Option<usize>)

cakebaker merged commit 9b3b9e8 into uutils:main Jun 27, 2024

BrewTestBot mentioned this pull request Nov 16, 2024

uutils-coreutils 0.0.28 Homebrew/homebrew-core#197947

Merged

moonfruit mentioned this pull request Nov 22, 2024

uutils-selected 0.0.28 moonfruit/homebrew-tap#178

Closed

Uh oh!

cksum/hashsum: add support of --check with base64 + other improvs #6452

cksum/hashsum: add support of --check with base64 + other improvs #6452

Uh oh!

Conversation

sylvestre commented Jun 4, 2024

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

github-actions bot commented Jun 4, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

github-actions bot commented Jun 18, 2024

Uh oh!

Uh oh!

github-actions bot commented Jun 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 26, 2024

Uh oh!

cakebaker commented Jun 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants