Skip to content

Conversation

@cakebaker
Copy link
Contributor

This PR removes all #[cfg(not(target_pointer_width = "128"))] to fix several "unexpected cfg condition value: 128" warnings in the CI (see, for example, https://github.com/uutils/coreutils/actions/runs/9151519099/job/25157662399#step:11:377).

@tertsdiepraam
Copy link
Member

Ohh nice! Love it when the tooling improves to catch stuff like this

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, remaining CI failures are known issues #6275 and #6419.

@BenWiederhake BenWiederhake merged commit a816960 into uutils:main May 20, 2024
@cakebaker cakebaker deleted the tests_remove_target_pointer_width_128 branch May 21, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants