Skip to content

Conversation

@cakebaker
Copy link
Contributor

This PR renames dragonflybsd to dragonfly because the former is an incorrect target_os.

@github-actions
Copy link

github-actions bot commented May 8, 2024

GNU testsuite comparison:

GNU test failed: tests/cp/link-deref. tests/cp/link-deref is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

Copy link
Collaborator

@BenWiederhake BenWiederhake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! https://doc.rust-lang.org/reference/conditional-compilation.html#target_os

Does exactly what it says on the tin 👍

Thinking about the future: Is there a way we can lint this?

@BenWiederhake BenWiederhake merged commit 8078fca into uutils:main May 8, 2024
@cakebaker cakebaker deleted the stdbuf_fix_invalid_target_os branch May 9, 2024 05:00
@cakebaker
Copy link
Contributor Author

Thinking about the future: Is there a way we can lint this?

Yes, it's already done in our CI, though currently it shows only warnings. It's a new lint that was recently added to Rust nightly (1.80): https://blog.rust-lang.org/2024/05/06/check-cfg.html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants