Skip to content

Disabling compare_xattrs cp and mv related tests on OpenBSD#6368

Merged
BenWiederhake merged 1 commit intouutils:mainfrom
jadijadi:remove-xattrs-tests
May 9, 2024
Merged

Disabling compare_xattrs cp and mv related tests on OpenBSD#6368
BenWiederhake merged 1 commit intouutils:mainfrom
jadijadi:remove-xattrs-tests

Conversation

@jadijadi
Copy link
Copy Markdown
Contributor

@jadijadi jadijadi commented May 6, 2024

The test_cp and test_mv have xattr related tests. They should be disabled on OpenBSD after commit 19d42c0 disabled the compare_xattrs function on OpenBSD.

Related to #6349
Fixes #6348

@BenWiederhake
Copy link
Copy Markdown
Collaborator

BenWiederhake commented May 6, 2024

Back in #6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)

@jadijadi
Copy link
Copy Markdown
Contributor Author

jadijadi commented May 6, 2024

Back in #6349 I silently assumed that you re-ran the tests to verify that the function-removal does not have any knock-on-effects. Thanks for following up on it, though! Let's make uutils work perfectly. :)

Right. My mistake. I ran tests before sending the PR but after the suggestion for the removal of the actual compare_xattrs I did it from my OpenBSD machine which does not have the git hooks for automatic tests. Had to push from my linux machine. Installing the hooks on OpenBSD machine to prevent this from happening again.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 6, 2024

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@cakebaker
Copy link
Copy Markdown
Contributor

cakebaker commented May 9, 2024

Can you please run cargo fmt?

@jadijadi jadijadi force-pushed the remove-xattrs-tests branch from 51c89ec to dc37f89 Compare May 9, 2024 15:42
@jadijadi
Disabling compare_xattrs cp and mv related tests on OpenBSD
8108d7a 
The test_cp and test_mv have xattr related tests. They should
be disabled on OpenBSD after commit 19d42c0 disabled the
compare_xattrs function on OpenBSD.

Fixes uutils#6348
@jadijadi jadijadi force-pushed the remove-xattrs-tests branch from dc37f89 to 8108d7a Compare May 9, 2024 15:43
@jadijadi
Copy link
Copy Markdown
Contributor Author

jadijadi commented May 9, 2024

Can you please run cargo fmt?

just did. and added tests and fmt to the hooks.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 9, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@BenWiederhake
Copy link
Copy Markdown
Collaborator

BenWiederhake commented May 9, 2024

Remaining failures are #6275 and #6333 – I'll keep repeating this until we find someone who can fix that problem :)

@BenWiederhake BenWiederhake merged commit 9303f8e into uutils:main May 9, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 23, 2024
Merged
@moonfruit moonfruit mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests in tests/common/util.rs fails on OpenBSD 7.5

3 participants

@jadijadi @BenWiederhake @cakebaker