Skip to content

clippy: fix warnings introduced with Rust 1.78#6330

Merged
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:clippy_fix_warnings_rust_1_78
May 2, 2024
Merged

clippy: fix warnings introduced with Rust 1.78#6330
sylvestre merged 1 commit intouutils:mainfrom
cakebaker:clippy_fix_warnings_rust_1_78

Conversation

@cakebaker
Copy link
Copy Markdown
Contributor

This PR fixes the clippy warnings introduced with Rust 1.78. In two cases I used #[allow(clippy::assigning_clones)] because the suggested changes didn't work.

@cakebaker cakebaker marked this pull request as draft May 2, 2024 14:27
@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_78 branch from b5d52b6 to 04c7a49 Compare May 2, 2024 14:30
@cakebaker cakebaker marked this pull request as ready for review May 2, 2024 14:33
@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_78 branch from 04c7a49 to 989da5a Compare May 2, 2024 14:40
@cakebaker
Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • fixed warning in df unit test

@sylvestre
Copy link
Copy Markdown
Contributor

the suggested changes didn't work.

do you have details ?
it might interest @samueltardieu

@cakebaker cakebaker force-pushed the clippy_fix_warnings_rust_1_78 branch from 989da5a to 1990105 Compare May 2, 2024 14:47
@cakebaker
Copy link
Copy Markdown
Contributor Author

Changes since last push:

  • reversed change from previous push, used #[allow(assigning_clones)] instead

@samueltardieu
Copy link
Copy Markdown
Contributor

samueltardieu commented May 2, 2024

Indeed, it looks like assigning_clones is a false positive here, as the entity is reassigned to the result of a computation on itself and is thus borrowed. I'll check that this has been properly registered as a bug on Clippy's side.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2024

GNU testsuite comparison:

Congrats! The gnu test tests/timeout/timeout is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants