everywhere: cleanup unused/unnecessary spellcheck-disabling#6295
Merged
sylvestre merged 14 commits intouutils:mainfrom Apr 30, 2024
Merged
everywhere: cleanup unused/unnecessary spellcheck-disabling#6295sylvestre merged 14 commits intouutils:mainfrom
sylvestre merged 14 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have lots of unnecessary
spell-checker:disable-THINGall over the place, 44 in fact. That means we wouldn't notice typos in those lines, so let's remove unnecessary stuff like that.I found this when watching @jadijadi's video about #6225, because he copy-pastes a non-sensical
spell-checker:disable-lineon an empty line.Code to find the unnecessary spellcheck-statements: https://gist.github.com/BenWiederhake/f43c386c957825b6109325c39a351cac
In the process, I also found that
tests/by-util/test_cat.rscould be simplified a little bit. Not sure if it's worth it, but now it's done.