multicall: add --list to list all utils#6251
Merged
sylvestre merged 1 commit intouutils:mainfrom May 1, 2024
Merged
Conversation
Contributor
|
is that testable ? :) |
Collaborator
Author
|
Maybe, I'll look into that later today. |
Collaborator
|
Related to testability: #6198 |
5d103fb to
b1ba249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6250
I've implemented it more or less like the busybox version now, by just matching on the string
--list. Ultimately, we might want to go for more sophisticated argument parsing in the multicall binary.It is a bit strange though, because all the other things that the multicall binary can do are implemented as subcommands. In other words, one of these is not like the others:
I think using
--makes sense to clearly separate it from the utils. Maybecompletionandmanpageshould be prefixed with--too?