Skip to content

multicall: add --list to list all utils#6251

Merged
sylvestre merged 1 commit intouutils:mainfrom
tertsdiepraam:multicall-list
May 1, 2024
Merged

multicall: add --list to list all utils#6251
sylvestre merged 1 commit intouutils:mainfrom
tertsdiepraam:multicall-list

Conversation

@tertsdiepraam
Copy link
Copy Markdown
Collaborator

Closes #6250

I've implemented it more or less like the busybox version now, by just matching on the string --list. Ultimately, we might want to go for more sophisticated argument parsing in the multicall binary.

It is a bit strange though, because all the other things that the multicall binary can do are implemented as subcommands. In other words, one of these is not like the others:

coreutils completion
coreutils manpage
coreutils --list

I think using -- makes sense to clearly separate it from the utils. Maybe completion and manpage should be prefixed with -- too?

@sylvestre
Copy link
Copy Markdown
Contributor

is that testable ? :)
without a test, it feels fragile

@tertsdiepraam
Copy link
Copy Markdown
Collaborator Author

Maybe, I'll look into that later today.

@BenWiederhake
Copy link
Copy Markdown
Collaborator

Related to testability: #6198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--list for the multicall binary

3 participants