ls --dired: adjust our code after GNU v9.5 #6144

sylvestre · 2024-03-29T16:20:36Z

regressed because of #6139

github-actions · 2024-03-29T16:56:37Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!

cakebaker · 2024-03-30T07:37:45Z

Did you see that test_ls_dired_hyperlink_disabled fails on Windows?

github-actions · 2024-03-30T15:07:48Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!

src/uu/ls/src/ls.rs

github-actions · 2024-03-31T01:00:07Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/dired is no longer failing!

BenWiederhake

Implements and tests exactly what's on the tin. Awesome!

github-actions · 2024-04-11T14:29:21Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

tertsdiepraam

There's a bit of a clap issue again here, I believe (but I don't have 9.5 installed yet so I can't check, I'll verify soon). The problem is that we are forcing the long format after all arguments have been processed by clap, whereas even the new GNU version, does it as soon as --dired is encountered. Hence, we'll probably be incompatible in this case:

ls --dired --format=vertical

Because GNU still overrides it but we don't. Not necessarity a super big problem, but something to be aware of. And please do correct me if I'm interpreting this wrong.

src/uu/ls/src/ls.rs

tests/by-util/test_ls.rs

github-actions · 2024-06-21T21:46:49Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!

Manages cases like: $ ls -R --dired --hyperlink a2 will show hyperlink $ ls -R --hyperlink --dired a2 won't

github-actions · 2024-06-22T08:16:49Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!
Congrats! The gnu test tests/timeout/timeout is no longer failing!

github-actions · 2024-06-22T18:15:40Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/dired is no longer failing!
Congrats! The gnu test tests/tr/tr is no longer failing!

tests/by-util/test_ls.rs

src/uu/ls/src/ls.rs

Closes: #6488 Co-authored-by: Daniel Hofstetter <[email protected]>

github-actions · 2024-06-23T19:39:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/dired is no longer failing!

sylvestre · 2024-06-23T20:28:29Z

I tried with https://docs.rs/clap/latest/clap/struct.ArgMatches.html#method.index_of but it doesn't work with the setTrue

github-actions · 2024-06-23T20:51:03Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!

src/uu/ls/src/dired.rs

…want to see the long format Co-authored-by: Daniel Hofstetter <[email protected]>

github-actions · 2024-06-24T08:53:42Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!

github-actions · 2024-06-24T08:55:22Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/dired is no longer failing!

cakebaker · 2024-06-24T11:41:56Z

Congrats! The gnu test tests/ls/dired is no longer failing!

Great, good job :)

sylvestre requested review from cakebaker and tertsdiepraam March 29, 2024 17:52

BenWiederhake requested changes Mar 30, 2024

View reviewed changes

src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved

sylvestre requested a review from BenWiederhake March 31, 2024 10:09

BenWiederhake approved these changes Mar 31, 2024

View reviewed changes

tertsdiepraam reviewed Apr 11, 2024

View reviewed changes

src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved

cakebaker reviewed Apr 11, 2024

View reviewed changes

tests/by-util/test_ls.rs Outdated Show resolved Hide resolved

cakebaker reviewed Apr 11, 2024

View reviewed changes

tests/by-util/test_ls.rs Outdated Show resolved Hide resolved

ls --dired: v9.5 automatically set --format=long

da11981

ls --dired: v9.5 --hyperlink is ignored if passed first

cd44a3d

Manages cases like: $ ls -R --dired --hyperlink a2 will show hyperlink $ ls -R --hyperlink --dired a2 won't

sylvestre mentioned this pull request Jun 22, 2024

ls: --dired && --format order does matter #6488

Closed

sylvestre requested a review from cakebaker June 22, 2024 08:39

cakebaker reviewed Jun 23, 2024

View reviewed changes

tests/by-util/test_ls.rs Show resolved Hide resolved

cakebaker reviewed Jun 23, 2024

View reviewed changes

src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved

cakebaker reviewed Jun 23, 2024

View reviewed changes

src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved

ls: --format will override the --dired option

4d70562

Closes: #6488 Co-authored-by: Daniel Hofstetter <[email protected]>

cakebaker reviewed Jun 24, 2024

View reviewed changes

src/uu/ls/src/dired.rs Outdated Show resolved Hide resolved

ls: If we have --dired --hyperlink, we don't show dired but we still …

ececddd

…want to see the long format Co-authored-by: Daniel Hofstetter <[email protected]>

cakebaker mentioned this pull request Jun 24, 2024

ls: --hyperlink -R omits parent dir when displaying child dir #6492

Closed

cakebaker merged commit 92c3de5 into uutils:main Jun 24, 2024

sylvestre deleted the dired branch June 24, 2024 19:37

BrewTestBot mentioned this pull request Nov 16, 2024

uutils-coreutils 0.0.28 Homebrew/homebrew-core#197947

Merged

moonfruit mentioned this pull request Nov 22, 2024

uutils-selected 0.0.28 moonfruit/homebrew-tap#178

Closed

naoNao89 mentioned this pull request Oct 5, 2025

ls: Compatibility Tracking Issue #1872

Open

57 tasks

Uh oh!

ls --dired: adjust our code after GNU v9.5 #6144

ls --dired: adjust our code after GNU v9.5 #6144

Uh oh!

Conversation

sylvestre commented Mar 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 29, 2024

Uh oh!

cakebaker commented Mar 30, 2024

Uh oh!

github-actions bot commented Mar 30, 2024

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2024

Uh oh!

BenWiederhake left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 11, 2024

Uh oh!

tertsdiepraam left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 21, 2024

Uh oh!

github-actions bot commented Jun 22, 2024

Uh oh!

github-actions bot commented Jun 22, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 23, 2024

Uh oh!

sylvestre commented Jun 23, 2024

Uh oh!

github-actions bot commented Jun 23, 2024

Uh oh!

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

cakebaker commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sylvestre commented Mar 29, 2024 •

edited

Loading

tertsdiepraam left a comment •

edited

Loading