config terminal simulation for specific stdios only #6125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
feature/config_terminal_simulation
branch
from
1b2dd29 to
807ae04
Compare
cre4ture
force-pushed
the
feature/config_terminal_simulation
branch
from
807ae04 to
684e1f9
Compare
cre4ture
force-pushed
the
feature/config_terminal_simulation
branch
from
684e1f9 to
08900b0
Compare
BenWiederhake
requested changes
Apr 6, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
Just a typo.
I must admit that I don't quite understand yet how this fixes the problem in #6121, but if @tertsdiepraam says so, then I'm sure it makes sense.
|
GNU testsuite comparison: |
cre4ture
force-pushed
the
feature/config_terminal_simulation
branch
from
08900b0 to
4bcd8cc
Compare
|
GNU testsuite comparison: |
BenWiederhake
approved these changes
Apr 7, 2024
Collaborator
BenWiederhake
left a comment
BenWiederhake
left a comment
There was a problem hiding this comment.
Looks good, thanks for handling the typo!
Since I don't understand the context of this PR, I don't want to be the person who clicks "merge". I suggest @tertsdiepraam instead. :)
cre4ture
force-pushed
the
feature/config_terminal_simulation
branch
3 times, most recently
from
22f3b37 to
e86dfdd
Compare
|
GNU testsuite comparison: |
cre4ture
force-pushed
the
feature/config_terminal_simulation
branch
from
e86dfdd to
537941b
Compare
Contributor
Author
|
@tertsdiepraam @BenWiederhake please review + merge if fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in PR #6121, it makes sense for tests to have more fine granular control over the terminal simulation.
This PR improves this.