cksum: permit repeated flags, handle overrides correctly, implement base64 output #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Mar 2, 2024
BenWiederhake
force-pushed
the
dev-cksum-repeat-and-flags
branch
from
6c39855 to
8f625b6
Compare
Collaborator
Author
|
Changes since last push:
|
Collaborator
Author
|
Only now I see that a similar, but older PR from @tertsdiepraam exists: #5122 |
Member
|
Yours can take priority. I haven't looked at mine in a while and I can always rebase it. |
cakebaker
reviewed
Mar 5, 2024
sylvestre
force-pushed
the
dev-cksum-repeat-and-flags
branch
from
8f625b6 to
01a64d1
Compare
|
GNU testsuite comparison: |
BenWiederhake
force-pushed
the
dev-cksum-repeat-and-flags
branch
from
01a64d1 to
133cdde
Compare
Collaborator
Author
|
Changes since last push: Just rebased, to demonstrate that it's still working. Is there anything missing? |
sylvestre
approved these changes
Mar 18, 2024
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
no, it is great, just busy. I will accept it once the CI is green
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes and tests three things:
--tagand--untaggedin any order, use the last occurrence.--algorithm.--base64flag.All three of these are GNU behavior bugs, i.e. GNU does it differently, and uutils wants to handle it like GNU does.
This is work towards #5998.
Note that
cksumis still woefully incomplete; most prominently, the-coption is missing.