mv, cp: add support for --update=none,all,older #4796

shinhs0506 · 2023-04-27T11:55:03Z

#4627 cover mv/update
test still failing because of diff in err messages

src/uu/cp/src/cp.rs

src/uu/mv/src/mv.rs

src/uucore/src/lib/mods/update_control.rs

sylvestre · 2023-04-28T19:10:57Z

i know it is the draft but don't forget the tests please :)

github-actions · 2023-05-01T04:08:51Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

src/uu/cp/cp.md

src/uu/mv/mv.md

tests/by-util/test_cp.rs

src/uucore/src/lib/mods/update_control.rs

github-actions · 2023-05-01T11:48:49Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!
Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

github-actions · 2023-05-02T01:14:30Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

tests/by-util/test_mv.rs

tests/by-util/test_cp.rs

src/uucore/src/lib/mods/update_control.rs

cakebaker

Overall great work :)

github-actions · 2023-05-02T21:49:46Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!

github-actions · 2023-05-03T10:37:36Z

GNU testsuite comparison:

Congrats! The gnu test tests/mv/update is no longer failing!
GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

cakebaker · 2023-05-03T13:22:11Z

Thanks :)

shinhs0506 added 3 commits April 27, 2023 04:47

core: introduce update controller for mv and cp

ecde4b6

mv: implement update=[switch]

0e8dd89

cp: implement update=[switch]

9dc84e9

uutils deleted a comment from github-actions bot Apr 27, 2023

cakebaker changed the title ~~Mv cp update~~ mv, cp: add support for --update=none Apr 28, 2023

sylvestre reviewed Apr 28, 2023

View reviewed changes

src/uu/cp/src/cp.rs Outdated Show resolved Hide resolved

sylvestre reviewed Apr 28, 2023

View reviewed changes

src/uu/mv/src/mv.rs Outdated Show resolved Hide resolved

sylvestre reviewed Apr 28, 2023

View reviewed changes

src/uucore/src/lib/mods/update_control.rs Outdated Show resolved Hide resolved

shinhs0506 added 5 commits April 30, 2023 18:53

core mv cp: update help doc for 'update' functionality

2f8df65

cp: write tests for --update

ed3ff10

mv: add tests for --update

78412c5

cp: move after help to md file

2f975e9

mv: move after help to md file

f83468d

shinhs0506 force-pushed the mv-cp-update branch from 5e1a874 to f83468d Compare May 1, 2023 03:03

shinhs0506 added 2 commits April 30, 2023 20:09

mv: resolve merge conflict

85ded23

cp: remove long help

b707b69

shinhs0506 changed the title ~~mv, cp: add support for --update=none~~ mv, cp: add support for --update=none,all,older May 1, 2023

sylvestre reviewed May 1, 2023

View reviewed changes

src/uu/cp/cp.md Outdated Show resolved Hide resolved

sylvestre reviewed May 1, 2023

View reviewed changes

src/uu/cp/cp.md Outdated Show resolved Hide resolved

sylvestre reviewed May 1, 2023

View reviewed changes

src/uu/cp/cp.md Outdated Show resolved Hide resolved

sylvestre reviewed May 1, 2023

View reviewed changes

src/uu/mv/mv.md Show resolved Hide resolved

sylvestre reviewed May 1, 2023

View reviewed changes

tests/by-util/test_cp.rs Outdated Show resolved Hide resolved

sylvestre reviewed May 1, 2023

View reviewed changes

src/uucore/src/lib/mods/update_control.rs Show resolved Hide resolved

shinhs0506 added 4 commits May 1, 2023 03:48

core: add docs for update control

c5327cf

cp: fix documentation

92e1b3f

mv: fix documentation

6625cfe

cp: fix typos

66a9169

core: fix typo in update control

60c0b66

shinhs0506 marked this pull request as ready for review May 2, 2023 02:18