ls: fix double quoting when color is enabled #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tertsdiepraam
force-pushed
the
ls-fix-double-quoting
branch
from
ca957df to
eb23a9c
Compare
When color was enabled the escape_name function was called twice which led to names like `hello world` being displayed as `"'hello world'".
tertsdiepraam
force-pushed
the
ls-fix-double-quoting
branch
from
eb23a9c to
626ed43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When color was enabled the escape_name function was called twice which led to names like
hello worldbeing displayed as"'hello world'".This double quoting also led to an incorrect calculation of the width of the name, which is now also fixed.
Fixes #3584