gnu/test: add the iso en_us locale to help with some tests#2753
Merged
tertsdiepraam merged 1 commit intouutils:mainfrom Feb 13, 2022
sylvestre:gnu-locale
Merged
gnu/test: add the iso en_us locale to help with some tests#2753tertsdiepraam merged 1 commit intouutils:mainfrom sylvestre:gnu-locale
tertsdiepraam merged 1 commit intouutils:mainfrom
sylvestre:gnu-locale
Conversation
Contributor
Author
|
Failed because |
Contributor
Author
|
tests/misc/sort-month failing is #3123 |
Contributor
Author
Contributor
Author
|
@tertsdiepraam I think we should merge it if you are ok with it |
Contributor
Author
|
The clippy warning is already fixed: #3124 |
Collaborator
|
Yeah looks good to me! |
Contributor
Author
|
@tertsdiepraam could you please land then ? :) |
Collaborator
|
I was waiting for jfinkels, but sure :) |
Contributor
Author
|
oh, ok, merci :) |
Collaborator
|
Hi! I think this will be great for revealing more errors. I don't know much about using locales (I'm on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2754
We are regressing deliberately because they are actual issues.
exprwith multibytes:expris failing with multibyte chars #3132sort -kisn't working well with other locales: sort -k doesn't handle locale #3123