Skip to content

tests/util: add a convenience wrapper to run a ucmd with root permissions #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sylvestre merged 4 commits into from
May 6, 2022
Merged

tests/util: add a convenience wrapper to run a ucmd with root permissions #2692

sylvestre merged 4 commits into from
May 6, 2022

Conversation

@jhscheer
Copy link
Contributor

@jhscheer jhscheer commented Sep 19, 2021

As far as I can tell the CICD tests do not run as root, however some functionality can only be tested with root permissions.
While tinkering with #2689 it became apparent to me that there's a need for a a convenience wrapper to run a ucmd with root permissions.
Please let me know if there's a better way to do this.

@jhscheer jhscheer mentioned this pull request Sep 19, 2021
Merged
@sylvestre
Copy link
Contributor

sylvestre commented Sep 20, 2021

Fails with:


failures:

---- common::util::tests::test_run_ucmd_as_root stdout ----
current_directory_resolved: 
run: sudo -E --non-interactive whoami
thread 'common::util::tests::test_run_ucmd_as_root' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/common/util.rs:965:14

@sylvestre
Copy link
Contributor

sylvestre commented Nov 20, 2021

For some reasons, I cannot restart the jobs for this tasks?!
could you please rebase it? rivy pushed some changes

@jhscheer
Copy link
Contributor Author

jhscheer commented Nov 21, 2021

@sylvestre done

sylvestre
sylvestre reviewed Jan 30, 2022
View reviewed changes
@sylvestre
Copy link
Contributor

sylvestre commented Mar 5, 2022

Many tests in the code coverage ci are failing

@sylvestre
Copy link
Contributor

sylvestre commented Mar 11, 2022

``768 failed tests``` it is a bit much :)

@jhscheer jhscheer mentioned this pull request Apr 24, 2022
Merged
@tertsdiepraam
Copy link
Member

tertsdiepraam commented Apr 24, 2022

@sylvestre Any reason this hasn't been merged yet? The CI looks good now.

@sylvestre
Copy link
Contributor

sylvestre commented Apr 24, 2022

@tertsdiepraam "CICD / Code Coverage (ubuntu-latest, unix) (pull_request) " are failing :)

jhscheer and others added 4 commits May 1, 2022 20:15
@sylvestre sylvestre force-pushed the run_ucmd_as_root branch from 4ec5ef1 to eaad6c5 Compare May 1, 2022 18:15
jfinkels
jfinkels approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@jfinkels jfinkels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would help me with #3438

@sylvestre
Copy link
Contributor

sylvestre commented May 6, 2022

sorry for the latency!

@sylvestre sylvestre merged commit 9ea8531 into uutils:main May 6, 2022
@sylvestre sylvestre mentioned this pull request May 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

@jfinkels jfinkels jfinkels approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jhscheer @sylvestre @tertsdiepraam @jfinkels