Skip to content

Conversation

@Gilnaa
Copy link
Contributor

@Gilnaa Gilnaa commented Apr 5, 2021

Based on and uses changes from #2011

@sylvestre sylvestre merged commit ff620b5 into uutils:master Apr 16, 2021
@Gilnaa Gilnaa deleted the fix_tests branch April 16, 2021 22:24
@jhscheer
Copy link
Contributor

You forgot some assert!(result.success); (and possibly others).
Please use the tip from #1982 before you commit.

take a look at tests/common/util.rs to see all the functions a CmdResult has
you can locally make these fields private (but please don't commit this!) and fix the resulting errors

I already fixed the ones in test_chown and test_id because I had PRs with merge conflicts.

@Gilnaa
Copy link
Contributor Author

Gilnaa commented Apr 17, 2021

Whoopse, missed that. i guess I was too fixated on stdout. Will do that from now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants