Merged
Conversation
sylvestre
requested changes
Mar 20, 2021
Contributor
sylvestre
left a comment
sylvestre
left a comment
There was a problem hiding this comment.
Looks good but would it be great to add a test !
- add a test for copying a file from one directory to another - add the desired behavior Fixes uutils#1823
nomius10
force-pushed
the
install_bugfix
branch
from
8b73832 to
7a91281
Compare
nomius10
commented
Mar 20, 2021
Contributor
Author
nomius10
left a comment
nomius10
left a comment
There was a problem hiding this comment.
For some reason I can't run any of the tests for install:
cargo test test_install_copy_file_leading_dot
cargo test --bin=install --package=uu_install
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
I think that has to do with the fact that currently install is not included in the busybox-like binary
Contributor
|
|
sylvestre
reviewed
Mar 20, 2021
Contributor
Author
|
I've snuck in a refactoring commit: I've renamed the file & directory names throughout the tests, since they gave a false impression that they all execute within the same directory ( Please do tell if I should revert |
nomius10
force-pushed
the
install_bugfix
branch
from
2d3dffa to
220ca78
Compare
Contributor
|
great, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIL path manipulation in rust is intentionally basic due to security concerns.
fixes #1823