test: install WebdriverIO packages as optional dev dependencies#510
test: install WebdriverIO packages as optional dev dependencies#510
Conversation
We must stay with [email protected] as long as we want to execute our test in node@8 (i.e. until node@14 enters LTS).
ctavan
force-pushed
the
extract-webdriver-dependencies
branch
3 times, most recently
from
d273ac3 to
2bb5684
Compare
ctavan
changed the title
ctavan
force-pushed
the
extract-webdriver-dependencies
branch
from
2bb5684 to
d82e954
Compare
WebdriverIO which we use for browser testing cannot be installed on some platforms like z/OS. In order to allow "Canary in the Goldmine" (https://github.com/nodejs/citgm) to be run on such platforms as well we need to install WebdriverIO as an optional devDependency. Unfortunately npm doesn't support this out-of-the-box, so we have to wrap the affected dependencies in a small local wrapper package. Fixes #509.
ctavan
force-pushed
the
extract-webdriver-dependencies
branch
from
d82e954 to
ec68588
Compare
|
@IgorTodorovskiIBM could you check if this branch now lets you run the Something like: (or clone the repo & checkout the |
|
I just tested it on z/OS and your wrapper solution works perfectly. Thank you so much! |
|
Cool! @broofa are you fine with this? |
|
Hmm... would https://github.com/bcoe/optional-dev-dependency offer a slightly less-complicated solution? |
broofa
left a comment
broofa
left a comment
There was a problem hiding this comment.
Approving since this works and I don't want to block this, but with the caveat that bcoe's module might avoid the need for a whole new subproject folder.
|
Oh, that looks promising. For whatever reason me googling for “optional npm dev dependencies” didn’t find it. I will give it a try! |
|
@IgorTodorovskiIBM based on @broofa's feedback I've now chosen a more elegant approach. Would you mind verifying that CITGM still passes on z/OS once again before we merge this? |
|
Very cool! CITGM still passes! Thanks! |
|
Thank you for your help in testing this, @IgorTodorovskiIBM! |
3 participants
No description provided.