feat: remove support for pre Node.js v4 Buffer API (#356)

ctavan · web-flow · commit b59b5c5ecad2 · 2020-01-23T13:12:51.000+01:00
BREAKING CHANGE: Remove support for generating v3 and v5 UUIDs in
Node.js&lt;4.x
diff --git a/src/md5.js b/src/md5.js
@@ -1,20 +1,10 @@
 import crypto from 'crypto';
 
 function md5(bytes) {
-  if (typeof Buffer.from === 'function') {
-    // Modern Buffer API
-    if (Array.isArray(bytes)) {
-      bytes = Buffer.from(bytes);
-    } else if (typeof bytes === 'string') {
-      bytes = Buffer.from(bytes, 'utf8');
-    }
-  } else {
-    // Pre-v4 Buffer API
-    if (Array.isArray(bytes)) {
-      bytes = new Buffer(bytes);
-    } else if (typeof bytes === 'string') {
-      bytes = new Buffer(bytes, 'utf8');
-    }
+  if (Array.isArray(bytes)) {
+    bytes = Buffer.from(bytes);
+  } else if (typeof bytes === 'string') {
+    bytes = Buffer.from(bytes, 'utf8');
   }
 
   return crypto
diff --git a/src/sha1.js b/src/sha1.js
@@ -1,20 +1,10 @@
 import crypto from 'crypto';
 
 function sha1(bytes) {
-  if (typeof Buffer.from === 'function') {
-    // Modern Buffer API
-    if (Array.isArray(bytes)) {
-      bytes = Buffer.from(bytes);
-    } else if (typeof bytes === 'string') {
-      bytes = Buffer.from(bytes, 'utf8');
-    }
-  } else {
-    // Pre-v4 Buffer API
-    if (Array.isArray(bytes)) {
-      bytes = new Buffer(bytes);
-    } else if (typeof bytes === 'string') {
-      bytes = new Buffer(bytes, 'utf8');
-    }
+  if (Array.isArray(bytes)) {
+    bytes = Buffer.from(bytes);
+  } else if (typeof bytes === 'string') {
+    bytes = Buffer.from(bytes, 'utf8');
   }
 
   return crypto
