Ensure GitHub Actions Installs Python Dependencies Like Local Docker Environment#103
Merged
david-waltermire merged 1 commit intousnistgov:mainfrom May 4, 2022
Conversation
aj-stein-nist
force-pushed
the
issue-1216-align-actions-docker-python-deps
branch
2 times, most recently
from
f8ae6ea to
17ae2d9
Compare
aj-stein-nist
added
the
Scope: CI/CD
Contributor
Author
|
@david-waltermire-nist I hit some silly hiccups but this is ready to review. IMPORTANT: this took me a long time to realize, but the @wesley-dean-gsa, can't add you as a formal reviewer. This is as the short-term quick fix for usnistgov/OSCAL#1216 before we move onto longer term enhancements. |
aj-stein-nist
force-pushed
the
issue-1216-align-actions-docker-python-deps
branch
from
17ae2d9 to
1bb667a
Compare
Also, remove dead code for unused SSH deployment post-refactors from before.
aj-stein-nist
force-pushed
the
issue-1216-align-actions-docker-python-deps
branch
from
1bb667a to
be66460
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This resolves misalignment between the local developer env for Docker and the managed GitHub Actions for runners where the latter did not install necessary deps for the content conversion script written in Python.
This will close usnistgov/OSCAL#1216 for short-term bug fixing, and long-term improvements will be continued in subsequent systemic improvements tracked in other issues cited in the comment.
All Submissions:
Changes to Core Features:
Have you added an explanation of what your changes do and why you'd like us to include them?Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?