Skip to content

Generate anchors#362

Merged
david-waltermire merged 5 commits intousnistgov:developfrom
JustKuzya:generate-anchors
Jun 7, 2023
Merged

Generate anchors#362
david-waltermire merged 5 commits intousnistgov:developfrom
JustKuzya:generate-anchors

Conversation

@JustKuzya
Copy link
Copy Markdown
Contributor

@JustKuzya JustKuzya commented May 11, 2023 •
edited by aj-stein-nist
Loading

Committer Notes

Mostly fixes usnistgov/OSCAL#1681

Added transformations to build in anchors for deep-linking the h1-h6. This part of the Fix spread over repos. The second part is in foot.html and schema-docs.scss

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@JustKuzya JustKuzya changed the base branch from main to develop May 11, 2023 21:24
david-waltermire
david-waltermire suggested changes May 12, 2023
View reviewed changes
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
@david-waltermire david-waltermire added this to the Metaschema 0.9.0 milestone May 12, 2023
wendellpiez
wendellpiez previously approved these changes May 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice -- my only suggestions are a bit tighter syntax. Impressive job by @JustKuzya and @nikitawootten-nist on this work item.

Comment thread toolchains/xslt-M4/document/json/object-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl
aj-stein-nist
aj-stein-nist suggested changes May 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks. I just have some few requested changes as it pertains to related changes explained in usnistgov/OSCAL#1789 (review).

Comment thread toolchains/xslt-M4/document/json/object-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
aj-stein-nist
aj-stein-nist reviewed May 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some recommendations on aligning the comments that we want to keep. Also, we need to fix up the class names as discussed to align with usnistgov/OSCAL#1789 (review).

Comment thread toolchains/xslt-M4/document/json/object-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
Comment thread toolchains/xslt-M4/document/xml/element-reference-html.xsl Outdated
@aj-stein-nist
Copy link
Copy Markdown
Contributor

aj-stein-nist commented May 30, 2023

@JustKuzya, did you get a chance to updated PR feedback? We will wrap up the sprint today so I wanted to know if we can close this out for this sprint or not.

@JustKuzya
Copy link
Copy Markdown
Contributor Author

JustKuzya commented May 30, 2023

Added the changes suggested above

@JustKuzya
Copy link
Copy Markdown
Contributor Author

JustKuzya commented May 30, 2023

Added suggested changes

@david-waltermire david-waltermire merged commit de47fed into usnistgov:develop Jun 7, 2023
@aj-stein-nist aj-stein-nist mentioned this pull request Jun 7, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@wendellpiez wendellpiez wendellpiez left review comments

@david-waltermire david-waltermire david-waltermire approved these changes

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Metaschema 0.9.0

Development

Successfully merging this pull request may close these issues.

Statically generate anchor tags in model documentation

4 participants

@JustKuzya @aj-stein-nist @wendellpiez @david-waltermire