Merged
Conversation
8 tasks
wendellpiez
previously approved these changes
Apr 4, 2023
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Thanks @david-waltermire-nist
aj-stein-nist
previously approved these changes
Apr 4, 2023
nikitawootten-nist
suggested changes
Apr 4, 2023
Contributor
nikitawootten-nist
left a comment
There was a problem hiding this comment.
A few questions below :)
Contributor
|
Is it ok I request a rebase against current develop to include #344 to make testing easier? I work around it, but it would be minorly helpful. :-) |
6 tasks
2f47ef8
added 2 commits
April 10, 2023 12:55
Updating regex to ensure proper support by PCRE dialects.
2f47ef8 to
cbcab49
Compare
Author
Done. |
Author
|
I believe this PR is ready to merge. I'll merge it once @nikitawootten-nist approves. |
nikitawootten-nist
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This set of changes are to cleanup a variety schemas.
All Submissions:
Changes to Core Features: