Conversation
nikitawootten-nist
force-pushed
the
nikitawootten-nist/codeowners
branch
from
067aa7e to
904167d
Compare
There was a problem hiding this comment.
@nikitawootten-nist
-- 1) it turns out that @Compton-NIST is not a member of the usnitgov/itl-oscal, and I cannot fix it because @aj-stein-nist is the maintainer. We should also review all the other usnistgov/its-oscal-* teams and update them.
-- 2) maybe some (critical) directories should remain protected and only its-oscal-admins should own the code in those directories currently owned by its-oscal-maintainers which does not even exist among usnistgov teams.
I just saw this update. You @iMichaela were added to the maintainer list and I removed myself.
You have to be logged in for itl-oscal-maintainers as it is a private group, or otherwise you will not see or you are logged in and you are not a member. For you that problem should now be solved. Let me know if you need anything else. |
Thank you, @aj-stein-nist , for updating the roles. I'll work with @nikitawootten-nist on the -- 1) , second part. |
iMichaela
left a comment
iMichaela
left a comment
There was a problem hiding this comment.
LGTM. The system reports an error because 2 groups (out of three used) are not public. The groups exist and have access to the repo. The fact that the 2 groups are not public might not be a problem (we operated this way before).
* Flatten codeowners * Update CODEOWNERS with feedback from the team
4 participants
Committer Notes
Codeowners file now defaults to
@usnistgov/itl-oscal-maintainers.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: