Conversation
GaryGapinski
left a comment
GaryGapinski
left a comment
There was a problem hiding this comment.
LGTM. Please inform FedRAMP that they must impose their (and that of anyone subject to FIPS 199) specific requirement for these FIPS 199/SP 800-60 attributes to be present.
There was a problem hiding this comment.
@Arminta-Jenkins-NIST can you please review the checklist in the PR template and check it for us? Also, can you rebase this pull request on develop to surpress the CI/CD failure checking an outdated Markdown link:
git checkout 1798-optional-security-sensitivity-level # to be sure
git fetch upstream
git pull -r upstream develop
git push upstream HEAD -f
|
@aj-stein-nist DONE Here is the result: PS C:\Users\ajj2\git\OSCAL> git push upstream HEAD -f
Everything up-to-date |
Thanks for that update, please also review the checklist with the boxes in the pull request form to let us know what is or is not complete From the PR generated from the template, links to issue completeness guidelines. Thanks! |
aj-stein-nist
force-pushed
the
1798-optional-security-sensitivity-level
branch
from
11dbab4 to
4e114c9
Compare
3 participants
Committer Notes
Made security-sensitivity-level and security-impact-level optional attributes. Closes #1798.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.