Skip to content

[WIP] Add approval assembly to encode a role, party, and approval date.#1038

Closed
ohsh6o wants to merge 9 commits intousnistgov:developfrom
ohsh6o:issue-1033-approvals-assembly
Closed

[WIP] Add approval assembly to encode a role, party, and approval date.#1038
ohsh6o wants to merge 9 commits intousnistgov:developfrom
ohsh6o:issue-1033-approvals-assembly

Conversation

@ohsh6o
Copy link
Copy Markdown
Contributor

@ohsh6o ohsh6o commented Oct 14, 2021 •
edited
Loading

Committer Notes

A follow-up to #1033, a recommended implementation for an approvals assembly to allow developers using OSCAL to encode approval data for given staff certain roles for a responsible-party at a certain date and time.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

wendellpiez and others added 9 commits August 27, 2021 17:45
@wendellpiez
Adding link to XML Jelly Sandwich OSCAL demos (usnistgov#1016)
7a55322
@Rene2mt
Adding Component Tutorial to Website (usnistgov#1015)
6381eee 
- Addressed issue usnistgov#854 creating a tutorial based on component definition content from PR usnistgov#935.
- Linked the tutorial in the learn and concepts sections of the website.
- Adjusting deployment workflows.
- Adding new website GitHub actions workflow.
- Adjusting workflows to decompose specific activities.

Co-authored-by: Rene Tshiteya <[email protected]>
Co-authored-by: Rene2mt <[email protected]>
Adding unique constraint to enforce unique set-parameter entries.
80ae9d4
@iMichaela
added XACTA 360 to the Tools page.
ca7337d
@iMichaela
Updated the tools table on the website.
1282467
@bradh
utils: fix SyntaxWarning on content validator (usnistgov#1026)
83615b8 
Resolves usnistgov#1025
@dependabot
Bump nokogiri from 1.11.5 to 1.12.5 in /docs (usnistgov#1029)
81abd81 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.5 to 1.12.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.11.5...v1.12.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@wendellpiez
Improvements to converter readme docs (usnistgov#1027)
3cbb38e 
* Improvements to readme docs for both XML-to-JSON and JSON-to-XML XSLT conversion pathways
@aj-stein-gsa
Add approval assembly to encode a role, party, and approval date.
fc8b3eb
@ohsh6o
Copy link
Copy Markdown
Contributor Author

ohsh6o commented Oct 14, 2021

@david-waltermire-nist, as part of this pull request, would you like to add examples to the examples in the oscal-content repo or will that not be a hard and fast requirement re "Have you included examples of how to use your new feature(s)?" item on the checklist?

@ohsh6o
Copy link
Copy Markdown
Contributor Author

ohsh6o commented Oct 14, 2021 •
edited
Loading

Also, re the failing test in one of the testing workflows in GitHub Actions, not sure what this is about:

/home/runner/work/OSCAL/OSCAL/git-content/oscal/src/metaschema/oscal_profile_metaschema.xml:263: element is-unique: Schemas validity error : Element '{http://csrc.nist.gov/ns/oscal/metaschema/1.0}is-unique': Duplicate key-sequence ['unique-profile-modify-set-parameter'] in unique identity-constraint '{http://csrc.nist.gov/ns/oscal/metaschema/1.0}unique-constraint-ids'.

Is this unrelated to the schema validation issue and Metaschema updates we discussed during pairing?

@david-waltermire
Copy link
Copy Markdown
Contributor

david-waltermire commented Oct 15, 2021

Please repoint this to use develop as the base branch instead of main

@ohsh6o ohsh6o changed the base branch from main to develop October 15, 2021 14:57
@ohsh6o
Copy link
Copy Markdown
Contributor Author

ohsh6o commented Oct 15, 2021

Please repoint this to use develop as the base branch instead of main

Done, have to fix a simple merge conflict. But will take care of that soon enough!

@ohsh6o
Copy link
Copy Markdown
Contributor Author

ohsh6o commented Oct 22, 2021

It would appear I did not actually update the notes from last week in the meeting around recommended updates to this PR. Bullets below.

  • As is, the current surface of the object is good that recommendation more or less stands.
  • Consider making it more generalized, not just approvals, perhaps activities or disposition; this is up for further discussion.
  • I had asked about how to connect that to a particular revision in revisions with href UUID linking and it was strongly suggested by NIST OSCAL devs not to do this. It is more complex than it sounds and will require big changes to allow those mechanics, it is advised not to do that.

@xee5ch xee5ch mentioned this pull request Nov 12, 2021
Merged
8 tasks
@aj-stein-nist
Copy link
Copy Markdown
Contributor

aj-stein-nist commented Nov 30, 2021

@david-waltermire-nist per conversation yesterday, I think this can be closed in favor of #1052.

(NOTE: I think I have limited read/write access to the project still, so I cannot close PRs/issues that not authored by me directly.)

@aj-stein-nist
Copy link
Copy Markdown
Contributor

aj-stein-nist commented Nov 30, 2021

Closed in favor of #1052.

@aj-stein-nist aj-stein-nist added this to the v1.1.0 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@ohsh6o @david-waltermire @aj-stein-nist @wendellpiez @iMichaela @bradh @aj-stein-gsa