You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): show 1.0 MB instead of 1024.0 KB at file size unit boundaries - #6560
formatFileSize picks the unit before rounding, so a size just under the next unit rounds up to 1024 of the smaller one:
formatFileSize(1048575) // "1024.0 KB", expected "1.0 MB"
formatFileSize(1073741823) // "1024.0 MB", expected "1.0 GB"
formatFileSize(1024 ** 5) // "1.0 undefined", no unit past TB
It's used for attachment metadata, the storage line in account settings and the byte-based usage limits.
The function now moves to the next unit when the rounded value reaches 1024, adds PB, and clamps the unit index to the list.
Added web/tests/format.test.ts: the boundary and PB cases fail before the change. All 200 web test files pass, tsc --noEmit --skipLibCheck is clean and biome is clean on the changed files.
No actionable comments were generated in the recent review.
Walkthrough
formatFileSize now clamps the selected unit, promotes values when rounding would display 1024, and supports PB. Tests cover byte and kilobyte values, unit-promotion boundaries, and petabyte-scale values.
Suggested reviewers: johnnyjoygh, bluedbird
Merge Risk: Minimal · up to 673c0
This change fixes file size display at unit boundaries, so values show as 1.0 MB instead of 1024.0 KB, and adds PB support. The resource stats section now uses the same formatter. The risk of merging is minimal.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: formatFileSize now shows 1.0 MB instead of 1024.0 KB at unit boundaries. The raw summary confirms the rounding-based unit promotion in web/src/utils/format.ts, and the…
Description check
The description explains the bug, gives before and after examples for formatFileSize, lists the affected usages, and describes the fix and the added tests. It matches the changeset in web/src/utils/fo…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: formatFileSize now shows 1.0 MB instead of 1024.0 KB at unit boundaries. The raw summary confirms the rounding-based unit promotion in web/src/utils/format.ts, and the title's scope fits the change.
Full details: Description check
Explanation
The description explains the bug, gives before and after examples for formatFileSize, lists the affected usages, and describes the fix and the added tests. It matches the changeset in web/src/utils/format.ts and web/tests/format.test.ts.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Added 673c03a: the admin resource stats section had its own copy of the size formatter (formatBytes in ResourceStatsSection.tsx) with the same boundary bug, so 1048575 bytes showed as "1024.0 KB" there too. It now uses formatFileSize. pnpm lint (tsc + biome) is clean and all 200 web test files pass.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatFileSizepicks the unit before rounding, so a size just under the next unit rounds up to 1024 of the smaller one:It's used for attachment metadata, the storage line in account settings and the byte-based usage limits.
The function now moves to the next unit when the rounded value reaches 1024, adds
PB, and clamps the unit index to the list.Added
web/tests/format.test.ts: the boundary and PB cases fail before the change. All 200 web test files pass,tsc --noEmit --skipLibCheckis clean and biome is clean on the changed files.