Skip to content

simplify ssh conn string #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shreddedbacon merged 2 commits into from
Aug 14, 2025
Merged

simplify ssh conn string #461

shreddedbacon merged 2 commits into from
Aug 14, 2025

Conversation

@smlx
Copy link
Member

@smlx smlx commented Aug 8, 2025 •
edited
Loading

This PR makes two changes to SSH connection string generation:

  1. only use -t and -p NN when necessary, instead relying on ssh defaults.
    Before:

    $ lagoon ssh --conn-string -p my-demo -e master 
ssh -t -p 22 [email protected]

$ lagoon ssh --conn-string -p my-demo -e master -s foo
ssh -t -p 22 [email protected] service=foo

    After:

    $ go run . ssh --conn-string -p my-demo -e master 
ssh [email protected]

$ go run . ssh --conn-string -p my-demo -e master -s foo
ssh -t [email protected] service=foo

  2. stop using -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no altogether, now that ssh-core has a static host key.

@smlx smlx marked this pull request as ready for review August 8, 2025 01:28
smlx added 2 commits August 14, 2025 11:48
@smlx @shreddedbacon
feat: simplify ssh conn-string generation by relying on ssh defaults
1894515 
* Only specify -p when the port != 22
* Only specify -t when non-standard prefix arguments (e.g. service=)
  will break the ssh auto-sensing of pty allocation.
@smlx @shreddedbacon
feat: stop generating insecure connection strings for ssh-core
2527e0b 
The ssh-core service now uses a fixed host key so we don't need to
continue generating an ssh string which ignores it.
@shreddedbacon shreddedbacon force-pushed the simplify-ssh-conn-string branch from 4b2283a to 2527e0b Compare August 14, 2025 01:48
@shreddedbacon shreddedbacon merged commit 2d26746 into main Aug 14, 2025
8 checks passed
@shreddedbacon shreddedbacon deleted the simplify-ssh-conn-string branch August 14, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smlx @shreddedbacon