Skip to content

chore: allow builder to set OS/ARCH #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shreddedbacon merged 2 commits into from
May 20, 2025
Merged

chore: allow builder to set OS/ARCH #447

shreddedbacon merged 2 commits into from
May 20, 2025

Conversation

@tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented May 20, 2025

A multiarch build defines its own OS and ARCH - this PR ensures that the build is built as the correct architecture for the destination instead of falling back to linux/amd64

shreddedbacon
shreddedbacon approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 nice spot

@tobybellwood
Copy link
Member Author

tobybellwood commented May 20, 2025

This builds correctly now:

tobybellwood@MacBook-Air lagoon-cli % docker run --rm -it --entrypoint sh uselagoon/lagoon-cli:pr-447 -c "apk add file && file /lagoon"
fetch https://dl-cdn.alpinelinux.org/alpine/v3.21/main/aarch64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.21/community/aarch64/APKINDEX.tar.gz
(1/2) Installing libmagic (5.46-r2)
(2/2) Installing file (5.46-r2)
Executing busybox-1.37.0-r12.trigger
OK: 17 MiB in 17 packages
/lagoon: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, BuildID[sha1]=8464c19f53d2705b3daf626c8ef4134204226d69, stripped

@shreddedbacon shreddedbacon merged commit f91b4ec into main May 20, 2025
8 checks passed
@shreddedbacon shreddedbacon deleted the arm64-binaries branch May 20, 2025 07:28
@tobybellwood tobybellwood mentioned this pull request Sep 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tobybellwood @shreddedbacon