fix: force token refresh with lagoon login #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddedbacon
force-pushed
the
login-reset-token
branch
from
4f96e88 to
769bbb2
Compare
3 tasks
CGoodwin90
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Checklist
This change forces the
lagoon logincommand to refresh the token. Previously this command would only refresh a token if it was invalid, effectively doing nothing.For users that use many keys, this can lead to problems where the token may be for another user that previously authenticated, but still had a valid token. With a user believing that
lagoon loginwas clearing out the token.This is addressed in #319, but that pull request has considerable changes that are breaking for users, so this pull request brings a version of that functionality to the current CLI format.