Skip to content

change: update output for Render functions #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shreddedbacon merged 2 commits into from
Aug 5, 2024
Merged

change: update output for Render functions #364

shreddedbacon merged 2 commits into from
Aug 5, 2024

Conversation

@CGoodwin90
Copy link
Contributor

@CGoodwin90 CGoodwin90 commented Jul 31, 2024

General Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for inclusion in changelog

Changes the render functions in the Output package to return strings, allowing for the output to be captured in command testing (here #358). Updates all relevant commands to the use the modified render functions.

@CGoodwin90 CGoodwin90 marked this pull request as ready for review July 31, 2024 03:02
@CGoodwin90 CGoodwin90 requested a review from shreddedbacon July 31, 2024 03:02
@shreddedbacon shreddedbacon merged commit 33d7950 into main Aug 5, 2024
@shreddedbacon shreddedbacon deleted the cmd-output branch August 5, 2024 23:20
@CGoodwin90 CGoodwin90 mentioned this pull request Aug 8, 2024
Merged
3 tasks
@shreddedbacon shreddedbacon changed the title Change: Updates the output for Render functions change: update output for Render functions Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreddedbacon shreddedbacon shreddedbacon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CGoodwin90 @shreddedbacon