Repository navigation
ci: pin pnpm/action-setup and bufbuild/buf-setup-action to commit SHAs - #134
Merged
Merged
Conversation
The release workflow runs with contents:write and pushes the version tags customers consume, so a hijacked mutable tag on either action could poison a release. Pin both to the commit their tag currently resolves to (pnpm/action-setup v4 -> v4.3.0, buf-setup-action v1 -> v1.50.0) in every workflow so the pins stay consistent; Dependabot (.github/dependabot.yaml) already tracks github-actions and will bump the SHAs. Co-authored-by: Codesmith Staging <[email protected]>
piob-io
approved these changes
Sep 3, 2026
rcooney-sh
marked this pull request as ready for review
September 3, 2026 22:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security hygiene (vulnagent campaign 2026-09, group
hg_3dbc8c793dda1728). Aikido flagged release.yml, which runs withcontents: writeand pushes the version tags customers consume, so a hijacked mutable tag on either action could poison a release. The same two actions are used identically in build.yml, lint.yml, test-action.yml and verify-build.yml, so all 12uses:lines are pinned to the same SHAs to keep the repo consistent.How to review:
b906affcis the commitpnpm/action-setup@v4resolves to today (v4.3.0; v4.4.0 exists but v4 has not been moved to it).a47c93e0isbufbuild/buf-setup-action@v1= v1.50.0. The existing.github/dependabot.yamlalready tracks github-actions daily and will bump these.Risk level: low
Breaking-change risk: none. The SHAs are the exact commits the floating tags currently resolve to, so every workflow runs the same action code as before.
Validation: SHAs verified with
git ls-remote. build, lint, test-action and verify-build run on pull_request and exercise the pinned actions in this PR's CI; release.yml is workflow_dispatch and is exercised on the next release.Rollback: revert the commit.
Covered problems: prb_d0f5fe6f8388dc0c
Aikido findings
Linear: https://linear.app/blacksmith-sh/issue/SEC-691/medium-3rd-party-github-actions-should-be-pinned
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.