Repository navigation
setup_builder: take the buildkitd GC keepDuration from the sticky disk response - #131
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
piob-io
marked this pull request as ready for review
September 2, 2026 21:47
devin-ai-integration
Bot
force-pushed
the
devin/1788385046-v2-server-gc-keep-duration
branch
from
September 4, 2026 14:09
0a05d46 to
5003303
Compare
bruce-y
approved these changes
Sep 4, 2026
…k response The backend now attaches buildkitd_config.gc_keep_duration_hours to the sticky disk it hands out (forwarded by the agent on GetStickyDisk), so the GC TTL can be set fleet-wide and per organization without an action release. The action converts the whole-hour value to a BuildKit duration and only overrides keepDuration; gc/all/parallelism keep their defaults. Values outside 1..8760h, non-integers, zero and a missing field fall back to the existing 192h default with a warning where applicable, so older agents and backends keep today's behavior. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The pinned @buf/blacksmith_vm-agent.bufbuild_es build already carries BuildkitdConfig, so the structural cast is unnecessary.
devin-ai-integration
Bot
force-pushed
the
devin/1788385046-v2-server-gc-keep-duration
branch
from
September 4, 2026 14:22
5003303 to
67f633c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets the backend control buildkitd's GC TTL (today hardcoded
keepDuration = "192h"inDEFAULT_BUILDKITD_CONFIG) per organization and fleet-wide, without an action release. No new request: the agent already resolves the sticky disk through the backend onGetStickyDisk, and that response now carriesbuildkitdConfig { gcKeepDurationHours }(FastActions/fa#5384, sourced from useblacksmith/web#12355).buildkitdConfigFromServer(hours)only overrideskeepDuration(72 → "72h");gc = true,all = true, parallelism and everything else stay as before. Missing/0(old agent or backend, non-dockerfile disks) → default silently; non-integer or outside1..8760→core.warning+ default. v1 (main) does not read the field and is unchanged.No dependency changes: the
@buf/blacksmith_vm-agent.bufbuild_esbuild pinned onrelease/v2(via #133) already includesBuildkitdConfig, so the field is read through the generated type. Rollout order is still free: an agent or backend without the field leaves it unset and the action keeps192h.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled. (Staging)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Link to Devin session: https://app.devin.ai/sessions/5c8deaae10f14cf49877e6f03ff873f9
Open in Devin Desktop: https://app.devin.ai/desktop/session/5c8deaae10f14cf49877e6f03ff873f9?variant=devin
Requested by: @piob-io