Skip to content

improve observability and readiness timeout for buildkitd startup (v2) - #113

Merged
ajwerner merged 1 commit into
release/v2from
devin/1783614799-v2-buildkitd-observability
Jul 10, 2026
Merged

ajwerner merged 1 commit into
release/v2from
devin/1783614799-v2-buildkitd-observability

Conversation

@ajwerner

@ajwerner ajwerner commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Ports #112 (merged to main / v1) onto release/v2. When buildkitd forks successfully but its gRPC workers aren't ready in time, the action falls back to a cold local builder without leaving any evidence of what the daemon was doing. This changes the worker-readiness timeout path to capture evidence and report the failure, and gives slow inits more time before falling back:

  • Raise buildkitdTimeoutMs from 30s → 120s: worker init can be slow when loading a large cache from the sticky disk, and a cold local-builder fallback costs far more than waiting.
  • On worker-readiness failure, tail the last 100 lines of /tmp/buildkitd.log into the job log (new logBuildkitdLogTail(), also reused by the post-step crash-log path) and call reporter.reportBuildPushActionFailure("BUILDER_STARTUP", ...) so the backend sees these fallbacks.
  • Report BPA_BUILDKITD_READY_DURATION_MS in a finally block so the metric is emitted on failure too, not just success.

Cherry-pick of 5fe3b77 with dist/ rebuilt against v2.

Link to Devin session: https://app.devin.ai/sessions/f9e26ad52787476784fe0848cd40551d
Requested by: @ajwerner


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled. (Staging)

@ajwerner ajwerner self-assigned this Jul 9, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@ajwerner
ajwerner marked this pull request as ready for review July 10, 2026 00:48
@ajwerner
ajwerner merged commit c8e74ab into release/v2 Jul 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants