Repository navigation
improve observability and readiness timeout for buildkitd startup (v2) - #113
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
piob-io
approved these changes
Jul 9, 2026
ajwerner
marked this pull request as ready for review
July 10, 2026 00:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports #112 (merged to main / v1) onto
release/v2. When buildkitd forks successfully but its gRPC workers aren't ready in time, the action falls back to a cold local builder without leaving any evidence of what the daemon was doing. This changes the worker-readiness timeout path to capture evidence and report the failure, and gives slow inits more time before falling back:buildkitdTimeoutMsfrom 30s → 120s: worker init can be slow when loading a large cache from the sticky disk, and a cold local-builder fallback costs far more than waiting./tmp/buildkitd.loginto the job log (newlogBuildkitdLogTail(), also reused by the post-step crash-log path) and callreporter.reportBuildPushActionFailure("BUILDER_STARTUP", ...)so the backend sees these fallbacks.BPA_BUILDKITD_READY_DURATION_MSin afinallyblock so the metric is emitted on failure too, not just success.Cherry-pick of
5fe3b77withdist/rebuilt against v2.Link to Devin session: https://app.devin.ai/sessions/f9e26ad52787476784fe0848cd40551d
Requested by: @ajwerner
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled. (Staging)